[jira] [Commented] (HIVE-17318) Make Hikari CP configurable using hive properties in hive-site.xml

[Antal Sinkovits (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HIVE-17318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470368#comment-16470368
 ] 

Antal Sinkovits commented on HIVE-17318:
----------------------------------------

Yes you are right [~pvary]

Apart from the MetaStoreConf change, the
[https://github.com/apache/hive/blob/master/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java#L4169]

needs to be updated as well, to use the constant defined in 
HikariCPDataSourceProvider, instead of the hardcoded value.

I've created a jira for it:
https://issues.apache.org/jira/browse/HIVE-19486

> Make Hikari CP configurable using hive properties in hive-site.xml
> ------------------------------------------------------------------
>
>                 Key: HIVE-17318
>                 URL: https://issues.apache.org/jira/browse/HIVE-17318
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Barna Zsombor Klara
>            Assignee: Barna Zsombor Klara
>            Priority: Major
>             Fix For: 3.0.0
>
>         Attachments: HIVE-17318.01.patch, HIVE-17318.02.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)