[
https://issues.apache.org/jira/browse/HIVE-19374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471624#comment-16471624
]
Peter Vary commented on HIVE-19374:
-----------------------------------
[~spena]: Thanks for your work on this!
We created a set of HMS API tests, so we can check the compatibility of the
changes, and test the expected responses for the HMS API calls in some time
back for the most important HMS API calls. You can see the work here:
[https://github.com/apache/hive/tree/master/standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client]
We would like to keep them up-to-date with every HMS API change so as mentioned
in HIVE-19371, it would be good to extend the current tests with the default
value, and the modification of the {{OwnerType}} field as well?
{{TestTablesCreateDropAlterTruncate.testCreateTableDefaultValues}}
[https://github.com/apache/hive/blob/master/standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java#L244]
and
{{TestTablesCreateDropAlterTruncate.testAlterTable}}
[https://github.com/apache/hive/blob/master/standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java#L662]
Also it would be nice to extend the TableBuilder to handle the new attribute as
well:
[https://github.com/apache/hive/blob/master/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/client/builder/TableBuilder.java]
We might address these issues in another jira, if you think that would be the
best way to handle this
> Parse and process ALTER TABLE SET OWNER command syntax
> ------------------------------------------------------
>
> Key: HIVE-19374
> URL: https://issues.apache.org/jira/browse/HIVE-19374
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
> Reporter: Sergio Peña
> Assignee: Sergio Peña
> Priority: Major
> Attachments: HIVE-19374.1.patch, HIVE-19374.2.patch,
> HIVE-19374.3.patch
>
>
> Subtask that parses the new alter table set owner syntax and implements code
> to call HMS to change the owner of a table to a user or a role.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
