[
https://issues.apache.org/jira/browse/HIVE-19373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473922#comment-16473922
]
Peter Vary commented on HIVE-19373:
-----------------------------------
Hi [~spena],
Thanks for the patch.
- Nit: In TableBuilder.java - there is an import with '*' - we usually try to
avoid those
- testCreateTableDefaultValues - the goal of this test is to test the default
values assigned by HMS. Please do not set the owner/ownertype when creating the
table, and check how HMS returns these fields if they were null in the create
request.
- testAlterTable - please change the owner and the ownerType to a different
value than the original ones. It might be a good idea to move these set
commands to the getTableWithAllParametersSet method.
Thanks for taking care of this too!
Peter
> Add test cases that verifies ALTER change owner type on the HMS
> ----------------------------------------------------------------
>
> Key: HIVE-19373
> URL: https://issues.apache.org/jira/browse/HIVE-19373
> Project: Hive
> Issue Type: Sub-task
> Components: Hive, Metastore
> Reporter: Sergio Peña
> Assignee: Sergio Peña
> Priority: Major
> Attachments: HIVE-19373.1.patch
>
>
> Subtask to add test cases that check the owner type of a table is changed on
> the HMS
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
