[ 
https://issues.apache.org/jira/browse/HIVE-18533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16474738#comment-16474738
 ] 

Sahil Takiar commented on HIVE-18533:
-------------------------------------

[~lirui] attached an updated patch and updated the RB. Addressed your first two 
comments. I agree simpler names are better. I removed the enum entirely since 
its not really Hive standard. I went with "spark-submit" and "spark-launcher", 
I wanted to keep the "spark" part because "spark-submit" should be a familiar 
term to most Spark uses.

For your third point, Are there any code changes required for this? Yes, we 
will have to update the wiki to point out that more jars need to be added. Do 
you know why the {{packaging/pom.xml}} file doesn't include the 
{{hive-spark-client.jar}} file?

> Add option to use InProcessLauncher to submit spark jobs
> --------------------------------------------------------
>
>                 Key: HIVE-18533
>                 URL: https://issues.apache.org/jira/browse/HIVE-18533
>             Project: Hive
>          Issue Type: Improvement
>          Components: Spark
>            Reporter: Sahil Takiar
>            Assignee: Sahil Takiar
>            Priority: Major
>         Attachments: HIVE-18533.1.patch, HIVE-18533.2.patch, 
> HIVE-18533.3.patch, HIVE-18533.4.patch, HIVE-18533.5.patch, 
> HIVE-18533.6.patch, HIVE-18533.7.patch, HIVE-18533.8.patch, 
> HIVE-18533.9.patch, HIVE-18533.91.patch, HIVE-18533.94.patch, 
> HIVE-18533.95.patch, HIVE-18533.96.patch, HIVE-18831.93.patch
>
>
> See discussion in HIVE-16484 for details.
> I think this will help with reducing the amount of time it takes to open a 
> HoS session + debuggability (no need launch a separate process to run a Spark 
> app).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to