[ 
https://issues.apache.org/jira/browse/HIVE-19495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475167#comment-16475167
 ] 

Matt McCline commented on HIVE-19495:
-------------------------------------

+1 LGTM tests pending.

The review comments can be deferred as follow up items.

Consider leveraging the new VectorRandomBatchSource / enhanced 
VectorRandomRowSource to drive lots of random data with interesting NULLs / 
isRepeating batches (if applicable) through the SerDe and verify the data comes 
out as expected.  Random schema and all types schema can be generated.

> Arrow SerDe itest failure
> -------------------------
>
>                 Key: HIVE-19495
>                 URL: https://issues.apache.org/jira/browse/HIVE-19495
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Serializers/Deserializers
>            Reporter: Eric Wohlstadter
>            Assignee: Teddy Choi
>            Priority: Major
>             Fix For: 3.1.0
>
>         Attachments: HIVE-19495.1.patch, HIVE-19495.2.patch
>
>
> "You tried to write a Bit type when you are using a ValueWriter of type 
> NullableMapWriter."



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to