[ https://issues.apache.org/jira/browse/HIVE-19490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477942#comment-16477942 ]
Hive QA commented on HIVE-19490: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12923674/HIVE-19490.6.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 14399 tests executed *Failed tests:* {noformat} TestMinimrCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=94) [infer_bucket_sort_num_buckets.q,infer_bucket_sort_reducers_power_two.q,parallel_orderby.q,bucket_num_reducers_acid.q,scriptfile1.q,infer_bucket_sort_map_operators.q,infer_bucket_sort_merge.q,root_dir_external_table.q,infer_bucket_sort_dyn_part.q,udf_using.q] org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[default_constraint] (batchId=163) org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[bucketizedhiveinputformat] (batchId=183) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/10993/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/10993/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-10993/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 3 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12923674 - PreCommit-HIVE-Build > Locking on Insert into for non native and managed tables. > --------------------------------------------------------- > > Key: HIVE-19490 > URL: https://issues.apache.org/jira/browse/HIVE-19490 > Project: Hive > Issue Type: Improvement > Components: Druid integration > Reporter: slim bouguerra > Assignee: slim bouguerra > Priority: Major > Labels: druid, locking > Attachments: HIVE-19490.2.patch, HIVE-19490.3.patch, > HIVE-19490.4.patch, HIVE-19490.5.patch, HIVE-19490.6.patch, HIVE-19490.patch > > > Current state of the art: > Managed non native table like Druid Tables, will need to get a Lock on Insert > into or insert Over write. The nature of this lock is set to Exclusive by > default for any non native table. > This implies that Inserts into Druid table will Lock any read query as well > during the execution of the insert into. IMO this lock (on insert into) is > not needed since the insert statement is appending data and the state of > loading it is managed partially by Hive Storage handler hook and part of it > by Druid. > What i am proposing is to relax the lock level to shared for all non native > tables on insert into operations and keep it as Exclusive Write for insert > Overwrite for now. > > Any feedback is welcome. > cc [~ekoifman] / [~ashutoshc] / [~jdere] / [~hagleitn] > Also am not sure what is the best way to unit test this currently am using > debugger to check if locks are what i except, please let me know if there is > a better way to do this. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)