[ 
https://issues.apache.org/jira/browse/HIVE-19578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16479587#comment-16479587
 ] 

Prasanth Jayachandran commented on HIVE-19578:
----------------------------------------------

Actually, let me put up another patch that retains temp list. getSize() does 
not have to be precise. We can return sparseMap.size() + tempListIdx which is 
sufficient enough. I tried this yesterday and for some reason few tests failed. 
I figured out what went wrong. 

 

> HLL merges tempList on every add
> --------------------------------
>
>                 Key: HIVE-19578
>                 URL: https://issues.apache.org/jira/browse/HIVE-19578
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Sergey Shelukhin
>            Assignee: Prasanth Jayachandran
>            Priority: Major
>         Attachments: HIVE-19578.1.patch, Screen Shot 2018-05-16 at 15.29.12 
> .png
>
>
>  See comments on HIVE-18866; this has significant perf overhead after the 
> even bigger overhead from hashing is removed.  !Screen Shot 2018-05-16 at 
> 15.29.12 .png!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to