[
https://issues.apache.org/jira/browse/HIVE-19615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16488110#comment-16488110
]
Jesus Camacho Rodriguez commented on HIVE-19615:
------------------------------------------------
I will revert this patch, also it seems to be causing new issues. Last run:
{code}
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12924590/HIVE-19504.01.patch
ERROR: -1 due to no test(s) being added or modified.
ERROR: -1 due to 10 failed/errored test(s), 14317 tests executed
Failed tests:
TestBeeLineExceptionHandling - did not produce a TEST-*.xml file (likely timed
out) (batchId=192)
TestBeeLineHistory - did not produce a TEST-*.xml file (likely timed out)
(batchId=192)
TestBeelineArgParsing - did not produce a TEST-*.xml file (likely timed out)
(batchId=192)
TestClientCommandHookFactory - did not produce a TEST-*.xml file (likely timed
out) (batchId=192)
TestHiveCli - did not produce a TEST-*.xml file (likely timed out) (batchId=192)
TestHiveSchemaTool - did not produce a TEST-*.xml file (likely timed out)
(batchId=192)
TestIncrementalRows - did not produce a TEST-*.xml file (likely timed out)
(batchId=192)
TestShutdownHook - did not produce a TEST-*.xml file (likely timed out)
(batchId=192)
TestTableOutputFormat - did not produce a TEST-*.xml file (likely timed out)
(batchId=192)
org.apache.hadoop.hive.cli.TestMiniDruidCliDriver.testCliDriver[druidmini_test1]
(batchId=254)
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/11166/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/11166/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-11166/
Messages:
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 10 tests failed
This message is automatically generated.
ATTACHMENT ID: 12924590 - PreCommit-HIVE-Build
{code}
I can reproduce the Druid failure locally.
> Proper handling of is null and not is null predicate when pushed to Druid
> -------------------------------------------------------------------------
>
> Key: HIVE-19615
> URL: https://issues.apache.org/jira/browse/HIVE-19615
> Project: Hive
> Issue Type: Bug
> Reporter: slim bouguerra
> Assignee: slim bouguerra
> Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-19615.2.patch, HIVE-19615.3.patch, HIVE-19615.patch
>
>
> Recent development in Druid introduced new semantic of null handling
> [here|https://github.com/b-slim/druid/commit/219e77aeac9b07dc20dd9ab2dd537f3f17498346]
> Based on those changes when need to honer push down of expressions with is
> null/ is not null predicates.
> The prosed fix overrides the mapping of Calcite Function to Druid Expression
> to much the correct semantic.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
