[ 
https://issues.apache.org/jira/browse/HIVE-19508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496997#comment-16496997
 ] 

Bharathkrishna Guruvayoor Murali commented on HIVE-19508:
---------------------------------------------------------

Thanks [~stakiar] for the review.

I am uploading patch file which incorporates the mentioned suggestions.

Mainly please review the following:
 # SparkStage class added (overrides equals, hashcode etc..)
 # For the unit test, I have redirected output stream to verify the output.
 # Refactored usage of the map to have SparkStage instead of String, but using 
toString() for places where name needs to be printed.
 # There is a HashSet to hold completed tasks in SparkJobMonitor :

{code:java}
 private final Set<String> completed = new HashSet<String>();
{code}
I kept this as String itself, instead of changing it to SparkStage. Please let 
me know if this is fine.

> SparkJobMonitor getReport doesn't print stage progress in order
> ---------------------------------------------------------------
>
>                 Key: HIVE-19508
>                 URL: https://issues.apache.org/jira/browse/HIVE-19508
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Spark
>            Reporter: Sahil Takiar
>            Assignee: Bharathkrishna Guruvayoor Murali
>            Priority: Major
>         Attachments: HIVE-19508.1.patch, HIVE-19508.2.patch
>
>
> You can end up with a progress output like this:
> {code}
> Stage-10_0: 0/29      Stage-11_0: 0/44        Stage-12_0: 0/11        
> Stage-13_0: 0/1 Stage-8_0: 258(+76)/468 Stage-9_0: 0/165
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to