[
https://issues.apache.org/jira/browse/HIVE-18766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16502337#comment-16502337
]
Sahil Takiar commented on HIVE-18766:
-------------------------------------
Few minor comments, overall LGTM:
* Line 138 of {{RemoteDriver}} is already creating a {{RpcConfiguration}}
object, so no need to create another one for {{getFutureTimeoutMs}}
* Instead of swallowing an exception from {{sendError}} can we just log it at
WARN level
> Race condition during shutdown of RemoteDriver, error messages aren't always
> sent
> ---------------------------------------------------------------------------------
>
> Key: HIVE-18766
> URL: https://issues.apache.org/jira/browse/HIVE-18766
> Project: Hive
> Issue Type: Sub-task
> Components: Spark
> Reporter: Sahil Takiar
> Assignee: Aihua Xu
> Priority: Major
> Attachments: HIVE-18766.1.patch
>
>
> When we send an error during shutdown of the {{RemoteDriver}}, we don't wait
> for the error message to be sent. We just send it and then close the RPC
> channel. For a graceful shutdown, that doesn't seem ideal. We should at least
> wait a bit for the RPC message to be sent before shutting things down. I ran
> some tests locally and its pretty easy to hit a situation where the error
> message doesn't even get sent to the {{SparkClientImpl}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
