[ https://issues.apache.org/jira/browse/HIVE-19769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16506823#comment-16506823 ]
Hive QA commented on HIVE-19769: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12926958/HIVE-19769.patch {color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 14516 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/11645/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/11645/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-11645/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12926958 - PreCommit-HIVE-Build > Create dedicated objects for DB and Table names > ----------------------------------------------- > > Key: HIVE-19769 > URL: https://issues.apache.org/jira/browse/HIVE-19769 > Project: Hive > Issue Type: Sub-task > Components: storage-api > Affects Versions: 3.0.0 > Reporter: Alan Gates > Assignee: Alan Gates > Priority: Major > Attachments: HIVE-19769.patch > > > Currently table names are always strings. Sometimes that string is just > tablename, sometimes it is dbname.tablename. Sometimes the code expects one > or the other, sometimes it handles either. This is burdensome for developers > and error prone. With the addition of catalog to the hierarchy, this becomes > even worse. > I propose to add two objects, DatabaseName and TableName. These will track > full names of each object. They will handle inserting default catalog and > database names when those are not provided. They will handle the conversions > to and from strings. > These will need to be added to storage-api because ValidTxnList will use it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)