[
https://issues.apache.org/jira/browse/HIVE-12192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16507170#comment-16507170
]
Hive QA commented on HIVE-12192:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12927184/HIVE-12192.13.patch
{color:red}ERROR:{color} -1 due to build exiting with an error
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/11665/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/11665/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-11665/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit
status 1 and output '+ date '+%Y-%m-%d %T.%3N'
2018-06-09 22:01:55.952
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-11665/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2018-06-09 22:01:55.954
+ cd apache-github-source-source
+ git fetch origin
+ git reset --hard HEAD
HEAD is now at 95ea9f5 HIVE-19794 : Disable removing order by from subquery in
GenericUDTFGetSplits (Prasanth J via Jason Dere)
+ git clean -f -d
+ git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
+ git reset --hard origin/master
HEAD is now at 95ea9f5 HIVE-19794 : Disable removing order by from subquery in
GenericUDTFGetSplits (Prasanth J via Jason Dere)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2018-06-09 22:01:57.244
+ rm -rf ../yetus_PreCommit-HIVE-Build-11665
+ mkdir ../yetus_PreCommit-HIVE-Build-11665
+ git gc
+ cp -R . ../yetus_PreCommit-HIVE-Build-11665
+ mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-11665/yetus
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh
/data/hiveptest/working/scratch/build.patch
fatal: git diff header lacks filename information when removing 0 leading
pathname components (line 1070)
error: patch failed:
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateSub.java:17
Falling back to three-way merge...
Applied patch to
'ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateSub.java' with
conflicts.
error: patch failed:
ql/src/test/results/clientpositive/infer_join_preds.q.out:1165
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/infer_join_preds.q.out'
with conflicts.
Going to apply patch with: git apply -p1
/data/hiveptest/working/scratch/build.patch:328: trailing whitespace.
/data/hiveptest/working/scratch/build.patch:40875: trailing whitespace.
FAILED: AssertionError java.lang.AssertionError: Client Execution was expected
to fail, but succeeded with error code 0 for fname=date_literal3.q
/data/hiveptest/working/scratch/build.patch:40948: trailing whitespace.
min -28830
/data/hiveptest/working/scratch/build.patch:40949: trailing whitespace.
max -28769
/data/hiveptest/working/scratch/build.patch:40952: trailing whitespace.
distinct_count 35
error: patch failed:
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateSub.java:17
Falling back to three-way merge...
Applied patch to
'ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateSub.java' with
conflicts.
error: patch failed:
ql/src/test/results/clientpositive/infer_join_preds.q.out:1165
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/infer_join_preds.q.out'
with conflicts.
U ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateSub.java
U ql/src/test/results/clientpositive/infer_join_preds.q.out
warning: squelched 26 whitespace errors
warning: 31 lines add whitespace errors.
+ result=1
+ '[' 1 -ne 0 ']'
+ rm -rf yetus_PreCommit-HIVE-Build-11665
+ exit 1
'
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12927184 - PreCommit-HIVE-Build
> Hive should carry out timestamp computations in UTC
> ---------------------------------------------------
>
> Key: HIVE-12192
> URL: https://issues.apache.org/jira/browse/HIVE-12192
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
> Reporter: Ryan Blue
> Assignee: Jesus Camacho Rodriguez
> Priority: Blocker
> Labels: timestamp
> Attachments: HIVE-12192.01.patch, HIVE-12192.02.patch,
> HIVE-12192.03.patch, HIVE-12192.04.patch, HIVE-12192.05.patch,
> HIVE-12192.06.patch, HIVE-12192.07.patch, HIVE-12192.08.patch,
> HIVE-12192.09.patch, HIVE-12192.10.patch, HIVE-12192.11.patch,
> HIVE-12192.12.patch, HIVE-12192.13.patch, HIVE-12192.patch
>
>
> Hive currently uses the "local" time of a java.sql.Timestamp to represent the
> SQL data type TIMESTAMP WITHOUT TIME ZONE. The purpose is to be able to use
> {{Timestamp#getYear()}} and similar methods to implement SQL functions like
> {{year}}.
> When the SQL session's time zone is a DST zone, such as America/Los_Angeles
> that alternates between PST and PDT, there are times that cannot be
> represented because the effective zone skips them.
> {code}
> hive> select TIMESTAMP '2015-03-08 02:10:00.101';
> 2015-03-08 03:10:00.101
> {code}
> Using UTC instead of the SQL session time zone as the underlying zone for a
> java.sql.Timestamp avoids this bug, while still returning correct values for
> {{getYear}} etc. Using UTC as the convenience representation (timestamp
> without time zone has no real zone) would make timestamp calculations more
> consistent and avoid similar problems in the future.
> Notably, this would break the {{unix_timestamp}} UDF that specifies the
> result is with respect to ["the default timezone and default
> locale"|https://cwiki.apache.org/confluence/display/Hive/LanguageManual+UDF#LanguageManualUDF-DateFunctions].
> That function would need to be updated to use the
> {{System.getProperty("user.timezone")}} zone.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
