[
https://issues.apache.org/jira/browse/HIVE-19569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16507176#comment-16507176
]
Hive QA commented on HIVE-19569:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
30s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
51s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
23s{color} | {color:blue} ql in master has 2285 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m
38s{color} | {color:blue} standalone-metastore in master has 216 extant
Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
37s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
7s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
31s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
31s{color} | {color:red} ql: The patch generated 1 new + 2 unchanged - 0 fixed
= 3 total (was 2) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
19s{color} | {color:red} standalone-metastore: The patch generated 3 new + 437
unchanged - 0 fixed = 440 total (was 437) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m
42s{color} | {color:red} standalone-metastore generated 5 new + 216 unchanged -
0 fixed = 221 total (was 216) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
37s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
11s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 29m 56s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:standalone-metastore |
| | Dead store to txnAddPartitionEventResponses in
org.apache.hadoop.hive.metastore.HiveAlterHandler.alterTable(RawStore,
Warehouse, String, String, String, Table, EnvironmentContext, IHMSHandler) At
HiveAlterHandler.java:org.apache.hadoop.hive.metastore.HiveAlterHandler.alterTable(RawStore,
Warehouse, String, String, String, Table, EnvironmentContext, IHMSHandler) At
HiveAlterHandler.java:[line 136] |
| | Dead store to txnCreateTableEventResponses in
org.apache.hadoop.hive.metastore.HiveAlterHandler.alterTable(RawStore,
Warehouse, String, String, String, Table, EnvironmentContext, IHMSHandler) At
HiveAlterHandler.java:org.apache.hadoop.hive.metastore.HiveAlterHandler.alterTable(RawStore,
Warehouse, String, String, String, Table, EnvironmentContext, IHMSHandler) At
HiveAlterHandler.java:[line 135] |
| | Dead store to txnDropTableEventResponses in
org.apache.hadoop.hive.metastore.HiveAlterHandler.alterTable(RawStore,
Warehouse, String, String, String, Table, EnvironmentContext, IHMSHandler) At
HiveAlterHandler.java:org.apache.hadoop.hive.metastore.HiveAlterHandler.alterTable(RawStore,
Warehouse, String, String, String, Table, EnvironmentContext, IHMSHandler) At
HiveAlterHandler.java:[line 134] |
| | Load of known null value in
org.apache.hadoop.hive.metastore.HiveAlterHandler.alterTable(RawStore,
Warehouse, String, String, String, Table, EnvironmentContext, IHMSHandler) At
HiveAlterHandler.java:in
org.apache.hadoop.hive.metastore.HiveAlterHandler.alterTable(RawStore,
Warehouse, String, String, String, Table, EnvironmentContext, IHMSHandler) At
HiveAlterHandler.java:[line 106] |
| | Nullcheck of handler at line 138 of value previously dereferenced in
org.apache.hadoop.hive.metastore.HiveAlterHandler.alterTable(RawStore,
Warehouse, String, String, String, Table, EnvironmentContext, IHMSHandler) At
HiveAlterHandler.java:138 of value previously dereferenced in
org.apache.hadoop.hive.metastore.HiveAlterHandler.alterTable(RawStore,
Warehouse, String, String, String, Table, EnvironmentContext, IHMSHandler) At
HiveAlterHandler.java:[line 112] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-11666/dev-support/hive-personality.sh
|
| git revision | master / 95ea9f5 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11666/yetus/diff-checkstyle-ql.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11666/yetus/diff-checkstyle-standalone-metastore.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11666/yetus/new-findbugs-standalone-metastore.html
|
| modules | C: ql standalone-metastore U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11666/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> alter table db1.t1 rename db2.t2 generates
> MetaStoreEventListener.onDropTable()
> -------------------------------------------------------------------------------
>
> Key: HIVE-19569
> URL: https://issues.apache.org/jira/browse/HIVE-19569
> Project: Hive
> Issue Type: Bug
> Components: Metastore, Standalone Metastore, Transactions
> Affects Versions: 3.0.0
> Reporter: Eugene Koifman
> Assignee: mahesh kumar behera
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-19569.01.patch
>
>
> When renaming a table within the same DB, this operation causes
> {{MetaStoreEventListener.onAlterTable()}} to fire but when changing DB name
> for a table it causes {{MetaStoreEventListener.onDropTable()}} +
> {{MetaStoreEventListener.onCreateTable()}}.
> The files from original table are moved to new table location.
> This creates confusing semantics since any logic in {{onDropTable()}} doesn't
> know about the larger context, i.e. that there will be a matching
> {{onCreateTable()}}.
> In particular, this causes a problem for Acid tables since files moved from
> old table use WriteIDs that are not meaningful with the context of new table.
> Current implementation is due to replication. This should ideally be changed
> to raise a "not supported" error for tables that are marked for replication.
> cc [~sankarh]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
