[
https://issues.apache.org/jira/browse/HIVE-19711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16511916#comment-16511916
]
Hive QA commented on HIVE-19711:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
33s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
29s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
30s{color} | {color:blue} beeline in master has 70 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
37s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 6m
26s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
6s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 6m
2s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
51s{color} | {color:red} root: The patch generated 57 new + 261 unchanged - 71
fixed = 318 total (was 332) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
12s{color} | {color:red} beeline: The patch generated 42 new + 73 unchanged -
63 fixed = 115 total (was 136) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
17s{color} | {color:red} itests/hive-unit: The patch generated 15 new + 188
unchanged - 8 fixed = 203 total (was 196) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 99 line(s) that end in whitespace. Use
git apply --whitespace=fix <<patch_file>>. Refer
https://git-scm.com/docs/git-apply {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
38s{color} | {color:red} beeline generated 14 new + 51 unchanged - 19 fixed =
65 total (was 70) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 6m
21s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
12s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 47m 30s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:beeline |
| | org.apache.hive.beeline.BeeLineOpts.getInitFiles() may expose internal
representation by returning BeeLineOpts.initFiles At BeeLineOpts.java:by
returning BeeLineOpts.initFiles At BeeLineOpts.java:[line 469] |
| | org.apache.hive.beeline.BeeLineOpts.setInitFiles(String[]) may expose
internal representation by storing an externally mutable object into
BeeLineOpts.initFiles At BeeLineOpts.java:by storing an externally mutable
object into BeeLineOpts.initFiles At BeeLineOpts.java:[line 473] |
| | org.apache.hive.beeline.BeeLineOpts.env should be package protected At
BeeLineOpts.java: At BeeLineOpts.java:[line 143] |
| | Possible null pointer dereference of task in
org.apache.hive.beeline.schematool.HiveSchemaTool.main(String[]) Dereferenced
at HiveSchemaTool.java:task in
org.apache.hive.beeline.schematool.HiveSchemaTool.main(String[]) Dereferenced
at HiveSchemaTool.java:[line 349] |
| |
org.apache.hive.beeline.schematool.HiveSchemaToolTaskAlterCatalog.execute()
passes a nonconstant String to an execute or addBatch method on an SQL
statement At HiveSchemaToolTaskAlterCatalog.java:to an execute or addBatch
method on an SQL statement At HiveSchemaToolTaskAlterCatalog.java:[line 73] |
| |
org.apache.hive.beeline.schematool.HiveSchemaToolTaskCreateCatalog.catalogExists(Statement)
may fail to clean up java.sql.ResultSet Obligation to clean up resource
created at HiveSchemaToolTaskCreateCatalog.java:up java.sql.ResultSet
Obligation to clean up resource created at
HiveSchemaToolTaskCreateCatalog.java:[line 91] is not discharged |
| |
org.apache.hive.beeline.schematool.HiveSchemaToolTaskCreateCatalog.getNextCatalogId(Statement)
may fail to clean up java.sql.ResultSet Obligation to clean up resource
created at HiveSchemaToolTaskCreateCatalog.java:up java.sql.ResultSet
Obligation to clean up resource created at
HiveSchemaToolTaskCreateCatalog.java:[line 107] is not discharged |
| |
org.apache.hive.beeline.schematool.HiveSchemaToolTaskMoveDatabase.updateCatalogNameInTable(Statement,
String, String, String, String, String, String, boolean) passes a nonconstant
String to an execute or addBatch method on an SQL statement At
HiveSchemaToolTaskMoveDatabase.java:String, String, boolean) passes a
nonconstant String to an execute or addBatch method on an SQL statement At
HiveSchemaToolTaskMoveDatabase.java:[line 88] |
| |
org.apache.hive.beeline.schematool.HiveSchemaToolTaskMoveTable.getDbId(Statement,
String, String) may fail to clean up java.sql.ResultSet Obligation to clean
up resource created at HiveSchemaToolTaskMoveTable.java:to clean up
java.sql.ResultSet Obligation to clean up resource created at
HiveSchemaToolTaskMoveTable.java:[line 114] is not discharged |
| |
org.apache.hive.beeline.schematool.HiveSchemaToolTaskMoveTable.updateDbNameForTable(Statement,
String, String, String, String, String, String, String) passes a nonconstant
String to an execute or addBatch method on an SQL statement At
HiveSchemaToolTaskMoveTable.java:String, String, String) passes a nonconstant
String to an execute or addBatch method on an SQL statement At
HiveSchemaToolTaskMoveTable.java:[line 134] |
| | Dead store to hmsConn in
org.apache.hive.beeline.schematool.HiveSchemaToolTaskValidate.validateSchemaTables(Connection)
At
HiveSchemaToolTaskValidate.java:org.apache.hive.beeline.schematool.HiveSchemaToolTaskValidate.validateSchemaTables(Connection)
At HiveSchemaToolTaskValidate.java:[line 190] |
| | Found reliance on default encoding in
org.apache.hive.beeline.schematool.HiveSchemaToolTaskValidate.findCreateTable(String,
List):in
org.apache.hive.beeline.schematool.HiveSchemaToolTaskValidate.findCreateTable(String,
List): new java.io.FileReader(String) At
HiveSchemaToolTaskValidate.java:[line 288] |
| | org.apache.hive.beeline.schematool.HiveSchemaToolTaskValidate.execute()
invokes System.exit(...), which shuts down the entire virtual machine At
HiveSchemaToolTaskValidate.java:down the entire virtual machine At
HiveSchemaToolTaskValidate.java:[line 92] |
| |
org.apache.hive.beeline.schematool.HiveSchemaToolTaskValidate.validateSequences(Connection)
makes inefficient use of keySet iterator instead of entrySet iterator At
HiveSchemaToolTaskValidate.java:keySet iterator instead of entrySet iterator
At HiveSchemaToolTaskValidate.java:[line 156] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-11767/dev-support/hive-personality.sh
|
| git revision | master / 93e33e1 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11767/yetus/diff-checkstyle-root.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11767/yetus/diff-checkstyle-beeline.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11767/yetus/diff-checkstyle-itests_hive-unit.txt
|
| whitespace |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11767/yetus/whitespace-eol.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11767/yetus/new-findbugs-beeline.html
|
| modules | C: . beeline itests/hive-unit U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11767/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> Refactor Hive Schema Tool
> -------------------------
>
> Key: HIVE-19711
> URL: https://issues.apache.org/jira/browse/HIVE-19711
> Project: Hive
> Issue Type: Bug
> Components: Hive
> Affects Versions: 3.0.0
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Minor
> Fix For: 4.0.0
>
> Attachments: HIVE-19711.01.patch, HIVE-19711.02.patch,
> HIVE-19711.03.patch
>
>
> HiveSchemaTool is an 1500 lines long class trying to do everything It shold
> be cut into multiple classes doing smaller components.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
