[
https://issues.apache.org/jira/browse/HIVE-19783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16512315#comment-16512315
]
Peter Vary commented on HIVE-19783:
-----------------------------------
Thanks [~vihangk1] for the review!
Updated the patch based on your comments:
- Refactored HiveMetaStore.isSubdirectory to FileUtils, which only uses strings
as input
- RawStore.getPartitionLocations got a new input parameter as a baseLocation,
and return location string only outside the location. Thus saving memory
- Added new test method, to see, that the partitions where the location is
outside the table location are removed too.
One more question remained open. If you have time, I would very much appreciate
your opinion on the matter.
Thanks,
Peter
> Retrieve only locations in HiveMetaStore.dropPartitionsAndGetLocations
> ----------------------------------------------------------------------
>
> Key: HIVE-19783
> URL: https://issues.apache.org/jira/browse/HIVE-19783
> Project: Hive
> Issue Type: Improvement
> Reporter: Peter Vary
> Assignee: Peter Vary
> Priority: Major
> Attachments: HIVE-19783.2.patch, HIVE-19783.patch
>
>
> Optimize further the dropTable command.
> Currently {{HiveMetaStore.dropPartitionsAndGetLocations}} retrieves the whole
> partition object, but we need only the locations instead.
> Create a RawStore method to retrieve only the locations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)