[
https://issues.apache.org/jira/browse/HIVE-19416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16514477#comment-16514477
]
Sergey Shelukhin edited comment on HIVE-19416 at 6/15/18 11:27 PM:
-------------------------------------------------------------------
c/p:
Permalink Edit Delete
sershe Sergey Shelukhin added a comment - 3 hours ago - edited
I've committed the 03 patch to master-txnstats branch for now.
I will keep the JIRA open to
1) Run the tests.
2) Address the feedback on 03 patch.
Please do all future work for transactional stats ON TOP OF master-txnstats
branch, in separate patches.
The epic patch to run the tests here should be made by diffing master with
master-txnstats.
I will periodically merge master to make sure it stays up to date; one can also
merge locally just to produce a patch for tests.
Given that the branch was just created, the 03 patch is good for now for a test
run.
The fix version for commits to the branch should be txnstats. We will bulk
change it to 4.0/3.1 when we merge the branch.
I'm going to clean up existing jiras and file smaller scope items.
cc Steve Yeom Eugene Koifman Gunther Hagleitner
Permalink Edit Delete
sershe Sergey Shelukhin added a comment - 3 hours ago
Steve Yeom
Can you update RB with 03 patch? Just to finish the review and perhaps file
some more follow up jiras.
Also can you make a list of things that are missing? There are some JIRAs
remaining as subtasks, I'm not sure if they are addressed as part of the epic
patch or not. I filed some known issue JIRAs, let me know if there's more.
Or is it just enough to fix the tests and it's good?
Update: apparently 03 patch is not good, we will create the branch again later
based on the 04-patch to come. The rest will remain the same.
was (Author: sershe):
c/p:
Permalink Edit Delete
sershe Sergey Shelukhin added a comment - 3 hours ago - edited
I've committed the 03 patch to master-txnstats branch for now.
I will keep the JIRA open to
1) Run the tests.
2) Address the feedback on 03 patch.
Please do all future work for transactional stats ON TOP OF master-txnstats
branch, in separate patches.
The epic patch to run the tests here should be made by diffing master with
master-txnstats.
I will periodically merge master to make sure it stays up to date; one can also
merge locally just to produce a patch for tests.
Given that the branch was just created, the 03 patch is good for now for a test
run.
The fix version for commits to the branch should be txnstats. We will bulk
change it to 4.0/3.1 when we merge the branch.
I'm going to clean up existing jiras and file smaller scope items.
cc Steve Yeom Eugene Koifman Gunther Hagleitner
Permalink Edit Delete
sershe Sergey Shelukhin added a comment - 3 hours ago
Steve Yeom
Can you update RB with 03 patch? Just to finish the review and perhaps file
some more follow up jiras.
Also can you make a list of things that are missing? There are some JIRAs
remaining as subtasks, I'm not sure if they are addressed as part of the epic
patch or not. I filed some known issue JIRAs, let me know if there's more.
Or is it just enough to fix the tests and it's good?
> Create single version transactional table metastore statistics for
> aggregation queries
> --------------------------------------------------------------------------------------
>
> Key: HIVE-19416
> URL: https://issues.apache.org/jira/browse/HIVE-19416
> Project: Hive
> Issue Type: Bug
> Components: Transactions
> Reporter: Steve Yeom
> Assignee: Steve Yeom
> Priority: Major
>
> The system should use only statistics for aggregation queries like count on
> transactional tables.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
