[ 
https://issues.apache.org/jira/browse/HIVE-11130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14605796#comment-14605796
 ] 

Aihua Xu commented on HIVE-11130:
---------------------------------

[~ctang.ma] [~alangates]  Can you guys review the code since you work on both 
Zookeeper and db locking, want to get your input. 

I'm trying to add explicit lock/unlock table/database to the interface since I 
believe the implementation should be different for different locking 
mechanisms. Zookeeper should lock the current table and the database as well, 
e.g. (the current implementation only locks the current table, which will cause 
issue and will be fixed in the parent jira HIVE-10984). 

This jira is only a refactoring to add the interface.  

> Refactoring the code so that HiveTxnManager interface will support 
> lock/unlock table/database object
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-11130
>                 URL: https://issues.apache.org/jira/browse/HIVE-11130
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Locking
>    Affects Versions: 2.0.0
>            Reporter: Aihua Xu
>            Assignee: Aihua Xu
>         Attachments: HIVE-11130.patch
>
>
> This is just a refactoring step which keeps the current logic, but it exposes 
> the explicit lock/unlock table and database  in HiveTxnManager which should 
> be implemented differently by the subclasses ( currently it's not. e.g., for 
> ZooKeeper implementation, we should lock table and database when we try to 
> lock the table).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to