[
https://issues.apache.org/jira/browse/HIVE-19916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525629#comment-16525629
]
Sergey Shelukhin commented on HIVE-19916:
-----------------------------------------
Unfortunately it's a pain to remove this call because the methods like
alterTable, etc are called from many places. It would have been better to never
get it from metastore, but to require all the callers to make sure write IDs
are available, so compile paths wouldn't need to do anything (they already get
writeIDs), and the other paths would need to initialize config, that would have
been easy to detect in early testing.
In the interest of time now I only removed metastore call from some obvious
paths.
If this breaks too many tests we might postpone this.
> master-txnstats branch - don't get write IDs from metastore when it's not safe
> ------------------------------------------------------------------------------
>
> Key: HIVE-19916
> URL: https://issues.apache.org/jira/browse/HIVE-19916
> Project: Hive
> Issue Type: Sub-task
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Priority: Major
> Attachments: HIVE-19916.patch, branch-19916.patch
>
>
> There's some code in original txn stats patch that may go to metastore to get
> write Ids. This code should not go to metastore, it should fail instead.
> HIVE-19382 should ensure that we have correct IDs already present during
> optimizer - they are using by e.g. materialized view optimizer, so they
> should be there; if they are not present, some integration might be needed so
> that txn stats optimizations also have access to those write Ids.
> cc [~jcamachorodriguez]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
