[
https://issues.apache.org/jira/browse/HIVE-19975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525857#comment-16525857
]
Sergey Shelukhin edited comment on HIVE-19975 at 6/28/18 3:12 AM:
------------------------------------------------------------------
I found out why the tests work.
in HiveMetaStore, HiveMetaStore::get_partitions_statistics_req method does not
propagate write ID to the next class (they are never extracted from the
request); so, it calls the overload without the stats check.
Also one of my test fixes introduced another issue downstream that also
disables the check silently after that is fixed.
I will fix both and commit a test that shows this problem.
was (Author: sershe):
I found out why the tests work.
in HiveMetaStore, HiveMetaStore::get_partitions_statistics_req method does not
propagate write ID to the next class (they are never extracted from the
request); so, it calls the overload without the stats check.
Also one of my test fixes introduced another issue downstream that also
disables the check silently after that.
I will fix both and commit a test that shows this problem.
> Checking writeIdList per table may not check the commit level of a partition
> on a partitioned table.
> ----------------------------------------------------------------------------------------------------
>
> Key: HIVE-19975
> URL: https://issues.apache.org/jira/browse/HIVE-19975
> Project: Hive
> Issue Type: Sub-task
> Components: Transactions
> Affects Versions: 4.0.0
> Reporter: Steve Yeom
> Assignee: Sergey Shelukhin
> Priority: Major
> Fix For: 4.0.0
>
>
> writeIdList is per table entity but stats for a partitioned table are per
> partition.
> I.e., each record in PARTITIONS has an independent stats.
> So if we check the validity of a partition's stats, we need to check in the
> context of
> a partiton.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
