[ https://issues.apache.org/jira/browse/HIVE-20015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528661#comment-16528661 ]
Hive QA commented on HIVE-20015: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12929565/HIVE-20015.1.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 13 failed/errored test(s), 14632 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniDruidCliDriver.testCliDriver[druid_timestamptz] (batchId=191) org.apache.hadoop.hive.cli.TestMiniDruidCliDriver.testCliDriver[druidmini_joins] (batchId=191) org.apache.hadoop.hive.cli.TestMiniDruidCliDriver.testCliDriver[druidmini_masking] (batchId=191) org.apache.hive.jdbc.TestTriggersWorkloadManager.testMultipleTriggers2 (batchId=247) org.apache.hive.jdbc.TestTriggersWorkloadManager.testTriggerCustomCreatedDynamicPartitions (batchId=247) org.apache.hive.jdbc.TestTriggersWorkloadManager.testTriggerCustomCreatedDynamicPartitionsMultiInsert (batchId=247) org.apache.hive.jdbc.TestTriggersWorkloadManager.testTriggerCustomCreatedDynamicPartitionsUnionAll (batchId=247) org.apache.hive.jdbc.TestTriggersWorkloadManager.testTriggerCustomCreatedFiles (batchId=247) org.apache.hive.jdbc.TestTriggersWorkloadManager.testTriggerCustomNonExistent (batchId=247) org.apache.hive.jdbc.TestTriggersWorkloadManager.testTriggerCustomReadOps (batchId=247) org.apache.hive.jdbc.TestTriggersWorkloadManager.testTriggerHighBytesRead (batchId=247) org.apache.hive.jdbc.TestTriggersWorkloadManager.testTriggerHighShuffleBytes (batchId=247) org.apache.hive.jdbc.TestTriggersWorkloadManager.testTriggerVertexRawInputSplitsNoKill (batchId=247) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/12272/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12272/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12272/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 13 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12929565 - PreCommit-HIVE-Build > Populate ArrayList with Constructor > ----------------------------------- > > Key: HIVE-20015 > URL: https://issues.apache.org/jira/browse/HIVE-20015 > Project: Hive > Issue Type: Improvement > Components: HiveServer2 > Affects Versions: 3.0.0, 4.0.0 > Reporter: BELUGA BEHR > Assignee: Daniel Voros > Priority: Trivial > Labels: newbie, noob > Attachments: HIVE-20015.1.patch > > > {code:title=MapWork.java} > public ArrayList<Operator<?>> getWorks() { > return new ArrayList<Operator<?>>(aliasToWork.values()); > } > public ArrayList<Path> getPaths() { > ArrayList<Path> ret=new ArrayList<>(); > ret.addAll(pathToAliases.keySet()); > return ret; > } > {code} > {{getWorks}} method correctly uses the constructor to populate the > {{ArrayList}}. Please update {{getPaths}} method to do the same, instead of > creating an empty array, then creating a new array to accommodate the > {{addAll}} request. -- This message was sent by Atlassian JIRA (v7.6.3#76005)