[
https://issues.apache.org/jira/browse/HIVE-20030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16530252#comment-16530252
]
Andrew Sherman commented on HIVE-20030:
---------------------------------------
[~kgyrtkirk] that is interesting, thanks for pointing out HIVE-20008.
With your change the problem is now worse :-) When I rebase, clean build, and
then try to run with IntelliJ I see
{code}
/Users/asherman/git/asf/hive/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
Warning:(239, 45) java: org.apache.hadoop.hive.ql.udf.generic.GenericUDFHash in
org.apache.hadoop.hive.ql.udf.generic has been deprecated
Error:(525, 70) java: incompatible types:
java.util.List<org.apache.hadoop.hive.ql.exec.Task<?>> cannot be converted to
java.util.List<org.apache.hadoop.hive.ql.exec.Task<? extends
java.io.Serializable>>
Warning:(1819, 48) java: HIVEMAPREDMODE in
org.apache.hadoop.hive.conf.HiveConf.ConfVars has been deprecated
Warning:(10924, 72) java: org.apache.hadoop.hive.ql.udf.generic.GenericUDFHash
in org.apache.hadoop.hive.ql.udf.generic has been deprecated
Error:(12207, 52) java: incompatible types:
java.util.List<org.apache.hadoop.hive.ql.exec.Task<?>> cannot be converted to
java.util.List<org.apache.hadoop.hive.ql.exec.Task<? extends
java.io.Serializable>>
Error:(12307, 30) java: incompatible types:
java.util.List<org.apache.hadoop.hive.ql.exec.Task<?>> cannot be converted to
java.util.List<org.apache.hadoop.hive.ql.exec.Task<? extends
java.io.Serializable>>
Warning:(13260, 43) java: isDir() in org.apache.hadoop.fs.FileStatus has been
deprecated
Warning:(13526, 61) java: HIVE_GROUPBY_ORDERBY_POSITION_ALIAS in
org.apache.hadoop.hive.conf.HiveConf.ConfVars has been deprecated
Error:(14766, 49) java: incompatible types:
java.util.List<org.apache.hadoop.hive.ql.exec.Task<?>> cannot be converted to
java.util.List<org.apache.hadoop.hive.ql.exec.Task<? extends
java.io.Serializable>>
{code}
In the code there are a lot of places where we use <? extends OperatorDesc> so
removing those is a much larger task than converting the few Operator<?> to
Operator<? extends OperatorDesc>>.
> Fix Java compile errors that show up in IntelliJ from ConvertJoinMapJoin.java
> and AnnotateRunTimeStatsOptimizer.java
> --------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-20030
> URL: https://issues.apache.org/jira/browse/HIVE-20030
> Project: Hive
> Issue Type: Task
> Reporter: Andrew Sherman
> Assignee: Andrew Sherman
> Priority: Major
> Attachments: HIVE-20030.1.patch
>
>
> For some reason the Java compiler in IntellJ is more strict that the Oracle
> jdk compiler. Maybe this is something that can be configured away, but as it
> is simple I propose to make the code more type correct.
> {code}
> /Users/asherman/git/asf/hive2/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java
> Error:(613, 24) java: no suitable method found for
> findOperatorsUpstream(java.util.List<org.apache.hadoop.hive.ql.exec.Operator<?
> extends
> org.apache.hadoop.hive.ql.plan.OperatorDesc>>,java.lang.Class<org.apache.hadoop.hive.ql.exec.ReduceSinkOperator>)
> method
> org.apache.hadoop.hive.ql.exec.OperatorUtils.<T>findOperatorsUpstream(org.apache.hadoop.hive.ql.exec.Operator<?>,java.lang.Class<T>)
> is not applicable
> (cannot infer type-variable(s) T
> (argument mismatch;
> java.util.List<org.apache.hadoop.hive.ql.exec.Operator<? extends
> org.apache.hadoop.hive.ql.plan.OperatorDesc>> cannot be converted to
> org.apache.hadoop.hive.ql.exec.Operator<?>))
> method
> org.apache.hadoop.hive.ql.exec.OperatorUtils.<T>findOperatorsUpstream(java.util.Collection<org.apache.hadoop.hive.ql.exec.Operator<?>>,java.lang.Class<T>)
> is not applicable
> (cannot infer type-variable(s) T
> (argument mismatch;
> java.util.List<org.apache.hadoop.hive.ql.exec.Operator<? extends
> org.apache.hadoop.hive.ql.plan.OperatorDesc>> cannot be converted to
> java.util.Collection<org.apache.hadoop.hive.ql.exec.Operator<?>>))
> method
> org.apache.hadoop.hive.ql.exec.OperatorUtils.<T>findOperatorsUpstream(org.apache.hadoop.hive.ql.exec.Operator<?>,java.lang.Class<T>,java.util.Set<T>)
> is not applicable
> (cannot infer type-variable(s) T
> (actual and formal argument lists differ in length))
> {code}
> and
> {code}
> /Users/asherman/git/asf/hive2/ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/AnnotateRunTimeStatsOptimizer.java
> Error:(76, 12) java: no suitable method found for
> addAll(java.util.List<org.apache.hadoop.hive.ql.exec.Operator<?>>)
> method java.util.Collection.addAll(java.util.Collection<? extends
> org.apache.hadoop.hive.ql.exec.Operator<? extends
> org.apache.hadoop.hive.ql.plan.OperatorDesc>>) is not applicable
> (argument mismatch;
> java.util.List<org.apache.hadoop.hive.ql.exec.Operator<?>> cannot be
> converted to java.util.Collection<? extends
> org.apache.hadoop.hive.ql.exec.Operator<? extends
> org.apache.hadoop.hive.ql.plan.OperatorDesc>>)
> method java.util.Set.addAll(java.util.Collection<? extends
> org.apache.hadoop.hive.ql.exec.Operator<? extends
> org.apache.hadoop.hive.ql.plan.OperatorDesc>>) is not applicable
> (argument mismatch;
> java.util.List<org.apache.hadoop.hive.ql.exec.Operator<?>> cannot be
> converted to java.util.Collection<? extends
> org.apache.hadoop.hive.ql.exec.Operator<? extends
> org.apache.hadoop.hive.ql.plan.OperatorDesc>>)
> Error:(80, 14) java: no suitable method found for
> addAll(java.util.Set<org.apache.hadoop.hive.ql.exec.Operator<?>>)
> method java.util.Collection.addAll(java.util.Collection<? extends
> org.apache.hadoop.hive.ql.exec.Operator<? extends
> org.apache.hadoop.hive.ql.plan.OperatorDesc>>) is not applicable
> (argument mismatch;
> java.util.Set<org.apache.hadoop.hive.ql.exec.Operator<?>> cannot be converted
> to java.util.Collection<? extends org.apache.hadoop.hive.ql.exec.Operator<?
> extends org.apache.hadoop.hive.ql.plan.OperatorDesc>>)
> method java.util.Set.addAll(java.util.Collection<? extends
> org.apache.hadoop.hive.ql.exec.Operator<? extends
> org.apache.hadoop.hive.ql.plan.OperatorDesc>>) is not applicable
> (argument mismatch;
> java.util.Set<org.apache.hadoop.hive.ql.exec.Operator<?>> cannot be converted
> to java.util.Collection<? extends org.apache.hadoop.hive.ql.exec.Operator<?
> extends org.apache.hadoop.hive.ql.plan.OperatorDesc>>)
> Error:(85, 14) java: no suitable method found for
> addAll(java.util.Set<org.apache.hadoop.hive.ql.exec.Operator<?>>)
> method java.util.Collection.addAll(java.util.Collection<? extends
> org.apache.hadoop.hive.ql.exec.Operator<? extends
> org.apache.hadoop.hive.ql.plan.OperatorDesc>>) is not applicable
> (argument mismatch;
> java.util.Set<org.apache.hadoop.hive.ql.exec.Operator<?>> cannot be converted
> to java.util.Collection<? extends org.apache.hadoop.hive.ql.exec.Operator<?
> extends org.apache.hadoop.hive.ql.plan.OperatorDesc>>)
> method java.util.Set.addAll(java.util.Collection<? extends
> org.apache.hadoop.hive.ql.exec.Operator<? extends
> org.apache.hadoop.hive.ql.plan.OperatorDesc>>) is not applicable
> (argument mismatch;
> java.util.Set<org.apache.hadoop.hive.ql.exec.Operator<?>> cannot be converted
> to java.util.Collection<? extends org.apache.hadoop.hive.ql.exec.Operator<?
> extends org.apache.hadoop.hive.ql.plan.OperatorDesc>>)
> /Users/asherman/git/asf/hive2/ql/target/generated-sources/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/IntervalYearMonthScalarAddTimestampColumn.java
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
