[
https://issues.apache.org/jira/browse/HIVE-19337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531659#comment-16531659
]
Zoltan Haindrich commented on HIVE-19337:
-----------------------------------------
+1
I think you are not following fully the patch naming conventions:
{code}
HIVE-<JIRA-NUMBER>[.<patch-num>][-<branch-name>].patch
{code}
I totally agree that HIVE-XXX.01.branch-name.patch would be more logical...but
somehow the above is the current format...
https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-AttachingandSubmittingaPatch
> Partition whitelist regex doesn't work (and never did)
> ------------------------------------------------------
>
> Key: HIVE-19337
> URL: https://issues.apache.org/jira/browse/HIVE-19337
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 2.3.3
> Reporter: Alexander Kolbasov
> Assignee: Alexander Kolbasov
> Priority: Major
> Attachments: HIVE-19337.01.branch-2.patch,
> HIVE-19337.03.branch-2.patch
>
>
> {{ObjectStore.setConf()}} has the following code:
> {code:java}
> String partitionValidationRegex =
>
> hiveConf.get(HiveConf.ConfVars.METASTORE_PARTITION_NAME_WHITELIST_PATTERN.name());
> {code}
> Note that it uses name() method which returns enum name
> (METASTORE_PARTITION_NAME_WHITELIST_PATTERN) rather then .varname
> As a result the regex will always be null.
> The code was introduced as part of
> HIVE-7223 Support generic PartitionSpecs in Metastore partition-functions
> So looks like this was broken since the original code drop. This is fixed in
> Hive3 - probably when [~alangates] reworked access to configuration
> (HIVE-17733) so it isn't a bug in Hive-3.
> [~stakiar_impala_496e] FYI.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
