[
https://issues.apache.org/jira/browse/HIVE-17849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531889#comment-16531889
]
Hive QA commented on HIVE-17849:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12893095/HIVE-17849.01-branch-2.3.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 14 failed/errored test(s), 10578 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[comments] (batchId=35)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_if_expr]
(batchId=142)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query64]
(batchId=229)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[cbo_simple_select]
(batchId=105)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[groupby1]
(batchId=105)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[groupby_multi_single_reducer2]
(batchId=105)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[input18]
(batchId=105)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[join26]
(batchId=105)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[join32]
(batchId=105)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[join_reorder2]
(batchId=105)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_join]
(batchId=105)
org.apache.hadoop.hive.ql.TestTxnCommands2.testNonAcidToAcidConversion02
(batchId=263)
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdate.testNonAcidToAcidConversion02
(batchId=275)
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testNonAcidToAcidConversion02
(batchId=272)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/12355/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12355/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12355/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 14 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12893095 - PreCommit-HIVE-Build
> alterPartition() may fail to rollback transaction
> -------------------------------------------------
>
> Key: HIVE-17849
> URL: https://issues.apache.org/jira/browse/HIVE-17849
> Project: Hive
> Issue Type: Bug
> Components: Hive
> Affects Versions: 2.3.0
> Reporter: Alexander Kolbasov
> Priority: Major
> Attachments: HIVE-17849.01-branch-2.3.patch
>
>
> In HiveAlterHandle.alterPartition() there is this code:
> {code}
> try {
> msdb.openTransaction();
> msdb.alterPartition(dbname, name, new_part.getValues(), oldPart);
> if (transactionalListeners != null &&
> !transactionalListeners.isEmpty()) {
> MetaStoreListenerNotifier.notifyEvent(transactionalListeners,
>
> EventMessage.EventType.ALTER_PARTITION,
> new
> AlterPartitionEvent(new_part, oldPart, tbl, success, handler));
> }
> revertMetaDataTransaction = msdb.commitTransaction();
> } catch (Exception ex2) {
> LOG.error("Attempt to revert partition metadata change failed.
> The revert was attempted " +
> "because associated filesystem rename operation failed with
> exception " + ex.getMessage(), ex2);
> if (!revertMetaDataTransaction) {
> msdb.rollbackTransaction();
> }
> }
> {code}
> Note that there is no {{finally}} clause, so it is possible for some
> unchecked exception to occur in which case the transaction will remain
> active. Once this happens, all subsequent transactions on this thread will
> not behave correctly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
