[
https://issues.apache.org/jira/browse/HIVE-20060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533156#comment-16533156
]
Hive QA commented on HIVE-20060:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
43s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
59s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
47s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m
55s{color} | {color:blue} standalone-metastore in master has 228 extant
Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
30s{color} | {color:blue} beeline in master has 56 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
35s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
42s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
22s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
35s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
19s{color} | {color:red} standalone-metastore: The patch generated 58 new + 67
unchanged - 126 fixed = 125 total (was 193) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
10s{color} | {color:red} beeline: The patch generated 2 new + 7 unchanged - 18
fixed = 9 total (was 25) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
18s{color} | {color:red} itests/hive-unit: The patch generated 2 new + 86
unchanged - 81 fixed = 88 total (was 167) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m
3s{color} | {color:red} standalone-metastore generated 6 new + 213 unchanged -
15 fixed = 219 total (was 228) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
38s{color} | {color:red} beeline generated 2 new + 51 unchanged - 5 fixed = 53
total (was 56) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
46s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
12s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 27m 28s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:standalone-metastore |
| | Found reliance on default encoding in
org.apache.hadoop.hive.metastore.tools.MetastoreSchemaTool.execSql(String):in
org.apache.hadoop.hive.metastore.tools.MetastoreSchemaTool.execSql(String): new
java.io.PrintStream(OutputStream) At MetastoreSchemaTool.java:[line 310] |
| |
org.apache.hadoop.hive.metastore.tools.SchemaToolTaskAlterCatalog.execute()
passes a nonconstant String to an execute or addBatch method on an SQL
statement At SchemaToolTaskAlterCatalog.java:to an execute or addBatch method
on an SQL statement At SchemaToolTaskAlterCatalog.java:[line 70] |
| | Found reliance on default encoding in
org.apache.hadoop.hive.metastore.tools.SchemaToolTaskCreateUser.oracleCreateUserHack(File):in
org.apache.hadoop.hive.metastore.tools.SchemaToolTaskCreateUser.oracleCreateUserHack(File):
new java.io.FileReader(File) At SchemaToolTaskCreateUser.java:[line 89] |
| | Found reliance on default encoding in
org.apache.hadoop.hive.metastore.tools.SchemaToolTaskCreateUser.subUserAndPassword(String,
String):in
org.apache.hadoop.hive.metastore.tools.SchemaToolTaskCreateUser.subUserAndPassword(String,
String): new java.io.FileReader(File) At SchemaToolTaskCreateUser.java:[line
69] |
| | Found reliance on default encoding in
org.apache.hadoop.hive.metastore.tools.SchemaToolTaskCreateUser.subUserAndPassword(String,
String):in
org.apache.hadoop.hive.metastore.tools.SchemaToolTaskCreateUser.subUserAndPassword(String,
String): new java.io.FileWriter(File) At SchemaToolTaskCreateUser.java:[line
67] |
| | Found reliance on default encoding in
org.apache.hadoop.hive.metastore.tools.SchemaToolTaskValidate.findCreateTable(String,
List):in
org.apache.hadoop.hive.metastore.tools.SchemaToolTaskValidate.findCreateTable(String,
List): new java.io.FileReader(String) At SchemaToolTaskValidate.java:[line
282] |
| FindBugs | module:beeline |
| | Found reliance on default encoding in
org.apache.hive.beeline.schematool.HiveSchemaTool.execSql(String):in
org.apache.hive.beeline.schematool.HiveSchemaTool.execSql(String): new
java.io.PrintStream(OutputStream) At HiveSchemaTool.java:[line 94] |
| | Found reliance on default encoding in
org.apache.hive.beeline.schematool.HiveSchemaTool.execSql(String, String):in
org.apache.hive.beeline.schematool.HiveSchemaTool.execSql(String, String): new
java.io.FileWriter(String) At HiveSchemaTool.java:[line 77] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-12386/dev-support/hive-personality.sh
|
| git revision | master / 5e2a530 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12386/yetus/diff-checkstyle-standalone-metastore.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12386/yetus/diff-checkstyle-beeline.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12386/yetus/diff-checkstyle-itests_hive-unit.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12386/yetus/new-findbugs-standalone-metastore.html
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12386/yetus/new-findbugs-beeline.html
|
| modules | C: standalone-metastore beeline itests/hive-unit U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12386/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> Refactor HiveSchemaTool and MetastoreSchemaTool
> -----------------------------------------------
>
> Key: HIVE-20060
> URL: https://issues.apache.org/jira/browse/HIVE-20060
> Project: Hive
> Issue Type: Task
> Components: Beeline, Metastore
> Reporter: Alan Gates
> Assignee: Alan Gates
> Priority: Major
> Attachments: HIVE-20060.patch
>
>
> These two classes are 95% the same. Now that HIVE-19711 has split
> HiveSchemaTool into multiple components it will be much easier to refactor
> these so that there is only one version of the code that each shares.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
