[
https://issues.apache.org/jira/browse/HIVE-17593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533260#comment-16533260
]
Junjie Chen commented on HIVE-17593:
------------------------------------
[~Ferd]， I may understand the definition in wrong way. As I listed definition
in above, length, comparison, and hashcode should be ignored for HiveChar, so
we should not change LENGTH(column) all to 5 in qtest result. Furthermore, I
checked HiveChar conversion in other places, such as
PrimitiveObjectInspectorConverter.java and PrimitiveObjectInspectorOrUtils.java
in hive serder2 package, they use stripped value explicitly.
So I think the easy way is to change ConvertAstToSeachArgs.java to use stripped
value for HiveChar as well.
> DataWritableWriter strip spaces for CHAR type before writing, but predicate
> generator doesn't do same thing.
> ------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-17593
> URL: https://issues.apache.org/jira/browse/HIVE-17593
> Project: Hive
> Issue Type: Bug
> Affects Versions: 2.3.0, 3.0.0
> Reporter: Junjie Chen
> Assignee: Junjie Chen
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.1.0
>
> Attachments: HIVE-17593.2.patch, HIVE-17593.3.patch, HIVE-17593.patch
>
>
> DataWritableWriter strip spaces for CHAR type before writing. While when
> generating predicate, it does NOT do same striping which should cause data
> missing!
> In current version, it doesn't cause data missing since predicate is not well
> push down to parquet due to HIVE-17261.
> Please see ConvertAstTosearchArg.java, getTypes treats CHAR and STRING as
> same which will build a predicate with tail spaces.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
