[ 
https://issues.apache.org/jira/browse/HIVE-20103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535636#comment-16535636
 ] 

Hive QA commented on HIVE-20103:
--------------------------------

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 
 4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
7s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
39s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m  
4s{color} | {color:blue} ql in master has 2287 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
55s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
56s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
12s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 23m 49s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-12437/dev-support/hive-personality.sh
 |
| git revision | master / 8494522 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: ql U: ql |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-12437/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> WM: Only Aggregate DAG counters if at least one is used
> -------------------------------------------------------
>
>                 Key: HIVE-20103
>                 URL: https://issues.apache.org/jira/browse/HIVE-20103
>             Project: Hive
>          Issue Type: Bug
>          Components: llap
>    Affects Versions: 3.0.0, 4.0.0
>            Reporter: Gopal V
>            Assignee: Gopal V
>            Priority: Major
>              Labels: Branch3Candidate
>         Attachments: HIVE-20103.1.patch
>
>
> {code}
>         status = 
> dagClient.getDAGStatus(EnumSet.of(StatusGetOpts.GET_COUNTERS), checkInterval);
>         TezCounters dagCounters = status.getDAGCounters();
> ...
>         if (dagCounters != null && wmContext != null) {
>           Set<String> desiredCounters = wmContext.getSubscribedCounters();
>           if (desiredCounters != null && !desiredCounters.isEmpty()) {
>             Map<String, Long> currentCounters = getCounterValues(dagCounters, 
> vertexNames, vertexProgressMap,
>               desiredCounters, done);
> {code}
> Skip collecting DAG counters unless there at least one desired counter in 
> wmContext.
> The AM has a hard-lock around the counters, so the current jstacks are full 
> of 
> {code}
>    java.lang.Thread.State: RUNNABLE
>         at java.lang.String.intern(Native Method)
>         at 
> org.apache.hadoop.util.StringInterner.weakIntern(StringInterner.java:71)
>         at 
> org.apache.tez.common.counters.GenericCounter.<init>(GenericCounter.java:50)
>         at 
> org.apache.tez.common.counters.TezCounters$GenericGroup.newCounter(TezCounters.java:65)
>         at 
> org.apache.tez.common.counters.AbstractCounterGroup.addCounterImpl(AbstractCounterGroup.java:92)
>         at 
> org.apache.tez.common.counters.AbstractCounterGroup.findCounter(AbstractCounterGroup.java:104)
>         - locked <0x00007efb3ac7af38> (a 
> org.apache.tez.common.counters.TezCounters$GenericGroup)
>         at 
> org.apache.tez.common.counters.AbstractCounterGroup.aggrAllCounters(AbstractCounterGroup.java:204)
>         at 
> org.apache.tez.common.counters.AbstractCounters.aggrAllCounters(AbstractCounters.java:372)
>         - eliminated <0x00007efb3ac64ee8> (a 
> org.apache.tez.common.counters.TezCounters)
>         at 
> org.apache.tez.common.counters.AbstractCounters.incrAllCounters(AbstractCounters.java:357)
>         - locked <0x00007efb3ac64ee8> (a 
> org.apache.tez.common.counters.TezCounters)
>         at 
> org.apache.tez.dag.app.dag.impl.TaskImpl.getCounters(TaskImpl.java:462)
>         at 
> org.apache.tez.dag.app.dag.impl.VertexImpl.aggrTaskCounters(VertexImpl.java:1342)
>         at 
> org.apache.tez.dag.app.dag.impl.VertexImpl.getAllCounters(VertexImpl.java:1202)
>         at 
> org.apache.tez.dag.app.dag.impl.DAGImpl.aggrTaskCounters(DAGImpl.java:755)
>         at 
> org.apache.tez.dag.app.dag.impl.DAGImpl.getAllCounters(DAGImpl.java:704)
>         at 
> org.apache.tez.dag.app.dag.impl.DAGImpl.getDAGStatus(DAGImpl.java:901)
>         at 
> org.apache.tez.dag.app.dag.impl.DAGImpl.getDAGStatus(DAGImpl.java:940)
>         at 
> org.apache.tez.dag.api.client.DAGClientHandler.getDAGStatus(DAGClientHandler.java:73)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to