[
https://issues.apache.org/jira/browse/HIVE-20047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16549651#comment-16549651
]
Sergey Shelukhin edited comment on HIVE-20047 at 7/19/18 6:20 PM:
------------------------------------------------------------------
Same test failures as on the main branch. I will commit this soon.
cc [~steveyeom2017] [~ekoifman] this removes the check for the same txn from
"isCompliant" method. And also simplifies all the APIs accordingly. So, it will
not rely entirely on write ID list being correct. Looks like it works.
was (Author: sershe):
Same test failures as on the main branch. I will commit this soon.
cc [~steveyeom2017] [~ekoifman] this removes the check for the same txn from
"isCompliant" method. So, it will not rely entirely on write ID list being
correct. Looks like it works.
> [phase 1.5] consider removing txnID argument for txn stats methods
> ------------------------------------------------------------------
>
> Key: HIVE-20047
> URL: https://issues.apache.org/jira/browse/HIVE-20047
> Project: Hive
> Issue Type: Sub-task
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Priority: Major
> Attachments: HIVE-20047.patch
>
>
> Followup from HIVE-19975.
> W.r.t. write IDs and txn IDs, stats validity check currently verifies one of
> two things - that stats write ID is valid for query write ID list, or that
> stats txn ID (derived from write ID) is the same as the query txn ID.
> I'm not sure the latter check is needed; removing it would allow us to make a
> bunch of APIs a little bit simpler.
> [~ekoifman] do you have any feedback? Can any stats reader (e.g. compile)
> observe stats written by the same txn; but in such manner that it doesn't
> have the write ID of the same-txn stats writer, in its valid write ID list?
> I'm assuming it's not possible, e.g. in multi statement txn each query would
> have the previous same-txn writer for the same table in its valid write ID
> list?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
