[ https://issues.apache.org/jira/browse/HIVE-20257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16560750#comment-16560750 ]
Hive QA commented on HIVE-20257: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12933454/HIVE-20257.2.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 14808 tests executed *Failed tests:* {noformat} TestMiniDruidCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=192) [druidmini_dynamic_partition.q,druidmini_expressions.q,druidmini_test_alter.q,druidmini_test1.q,druidmini_test_insert.q] org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[setop_no_distinct] (batchId=86) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/12920/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12920/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12920/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 2 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12933454 - PreCommit-HIVE-Build > Improvements to Hive.java > ------------------------- > > Key: HIVE-20257 > URL: https://issues.apache.org/jira/browse/HIVE-20257 > Project: Hive > Issue Type: Improvement > Affects Versions: 3.0.0, 4.0.0 > Reporter: BELUGA BEHR > Assignee: BELUGA BEHR > Priority: Minor > Fix For: 4.0.0 > > Attachments: HIVE-20257.1.patch, HIVE-20257.2.patch > > > Various fixes to {{Hive.java}} > * Use Log4J parameters in logging statements > * Fix check styles > * Make code more concise > * Remove "log and throw" code > * Replaced calls to deprecated code > * Removed superfluous calls to {{toString}} > > "log and throw" is considered and anti-pattern. Only the highest level catch > should be providing detailed logging otherwise we print the same stack trace > to the logs several times and with different context (for example when an > exception is wrapped, we get two different logging events). > > https://community.oracle.com/docs/DOC-983543#logAndThrow -- This message was sent by Atlassian JIRA (v7.6.3#76005)