[ 
https://issues.apache.org/jira/browse/HIVE-20291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16566163#comment-16566163
 ] 

ASF GitHub Bot commented on HIVE-20291:
---------------------------------------

GitHub user beltran opened a pull request:

    https://github.com/apache/hive/pull/406

    HIVE-20291: Allow HiveStreamingConnection to receive a WriteId

    This PR does the following:
    * Extract some classes from HiveStreamingConnection and put them in the 
transaction package (`TransactionBatch`, `TxnState`). This was done because I 
was planning to add `UnManagedSingleTransaction` and it was going to result in 
a too big class
    * Create `UnManagedSingleTransaction`, and make it inherit from 
`AbstractStreamingTransaction`, make `TransactionBatch` inherit from it as well.
    * Allow `AbstractRecordWriter` to receive a `StatementIdChooser`. The 
implementation of `StatementIdChooser` can be tricky because it needs to try to 
provide a unique statement id but it can retry if this id is not unique. This 
may happen in several nodes at the same time. At the moment a naive 
implementation has been done.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/beltran/hive HIVE-20291

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/hive/pull/406.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #406
    
----
commit 4cc9a182c0aa0e53096d25a1975038fa4a00c02d
Author: Jaume Marhuenda <jaumemarhuenda@...>
Date:   2018-07-30T21:57:29Z

    HIVE-20291: Allow HiveStreamingConnection to receive a WriteId

----


> Allow HiveStreamingConnection to receive a WriteId
> --------------------------------------------------
>
>                 Key: HIVE-20291
>                 URL: https://issues.apache.org/jira/browse/HIVE-20291
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Jaume M
>            Assignee: Jaume M
>            Priority: Major
>              Labels: pull-request-available
>
> If the writeId is received externally it won't need to open connections to 
> the metastore. It won't be able to the commit in this case as well so it must 
> be done by the entity passing the writeId.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to