[
https://issues.apache.org/jira/browse/HIVE-20350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576244#comment-16576244
]
Hive QA commented on HIVE-20350:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12935096/HIVE-20350.01.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 14873 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/13147/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/13147/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-13147/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12935096 - PreCommit-HIVE-Build
> Unnecessary value assignment
> ----------------------------
>
> Key: HIVE-20350
> URL: https://issues.apache.org/jira/browse/HIVE-20350
> Project: Hive
> Issue Type: Improvement
> Reporter: Laszlo Pinter
> Assignee: Laszlo Pinter
> Priority: Minor
> Attachments: HIVE-20350.01.patch, HIVE-20350.patch
>
>
> There is an unnecessary value assignment in Hive.java
> {code:java}
> newPartPath = oldPartPath == null ? newPartPath = genPartPathFromTable(tbl,
> partSpec,
> tblDataLocationPath) : oldPartPath;{code}
> This can be changed to
> {code:java}
> newPartPath = oldPartPath == null ? genPartPathFromTable(tbl, partSpec,
> tblDataLocationPath) : oldPartPath;{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
