[
https://issues.apache.org/jira/browse/HIVE-10882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14621354#comment-14621354
]
Ashutosh Chauhan commented on HIVE-10882:
-----------------------------------------
Patch LGTM
I have a comment similar to HIVE-11206 that if we can refactor
HiveOpConverter::translateJoin() and
SemanticAnalyzer::genJoinOperatorChildren() to share code when they construct
Join Operator, that will be better, since both functions generate Join Operator
albeit from different sources. It will be great if same code generates that
Join operator.
Also, judging from failure above, it seems this one requires HIVE-11197
> CBO: Calcite Operator To Hive Operator (Calcite Return Path) empty filtersMap
> of join operator causes wrong results
> -------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-10882
> URL: https://issues.apache.org/jira/browse/HIVE-10882
> Project: Hive
> Issue Type: Sub-task
> Components: CBO
> Reporter: Pengcheng Xiong
> Assignee: Jesus Camacho Rodriguez
> Attachments: HIVE-10882.01.patch
>
>
> CBO return path creates join operator with empty filtersMap. This causes
> outer joins to produce wrong results. To reproduce, run louter_join_ppr.q
> with return path turned on.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
