[
https://issues.apache.org/jira/browse/HIVE-20191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16587831#comment-16587831
]
Vihang Karajgaonkar edited comment on HIVE-20191 at 8/21/18 6:25 PM:
---------------------------------------------------------------------
+1 Thanks for the providing the fix.
was (Author: vihangk1):
+1 Thank for the providing the fix.
> PreCommit patch application doesn't fail if patch is empty
> ----------------------------------------------------------
>
> Key: HIVE-20191
> URL: https://issues.apache.org/jira/browse/HIVE-20191
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure
> Reporter: Daniel Voros
> Assignee: Daniel Voros
> Priority: Major
> Attachments: HIVE-20191.1.patch
>
>
> I've created some backport tickets to branch-3 (e.g. HIVE-20181) and made the
> mistake of uploading the patch files with wrong filename ({{.}} instead of
> {{-}} between version and branch).
> These get applied on master, where they're already present, since {{git
> apply}} with {{-3}} won't fail if patch is already there. Tests are run on
> master instead of failing.
> I think the patch application should fail if the patch is empty and branch
> selection logic should probably fail too if the patch name is malformed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
