[
https://issues.apache.org/jira/browse/HIVE-20257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591996#comment-16591996
]
Vihang Karajgaonkar commented on HIVE-20257:
--------------------------------------------
Hi [~belugabehr] Thanks for providing the patch. I took a quick look and I have
some suggestions below:
1. The patch changes the return type of one of the method to
{{Collections.singletonList(part);}} which is a immutable list. This is
semantically different than what was happening previously and I am not sure if
the calling method hierarchy assumes a immutable list. I would suggest to to
keep it the way it is or change to \{{Arrays.asList(part)}}.
2. I think changing {{final List<Future<ObjectPair<Path, Path>>> futures = new
LinkedList<>();}} to \{{final List<Future<ObjectPair<Path, Path>>> futures =
new ArrayList<>();}} is unnecessary.
Also, Is there a particular advantage of using StringUtils, ArrayUtils and
MapUtils to check for null or empty objects? Is the change only for improving
readability of there is something more to it.
> Improvements to Hive.java
> -------------------------
>
> Key: HIVE-20257
> URL: https://issues.apache.org/jira/browse/HIVE-20257
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 3.0.0, 4.0.0
> Reporter: BELUGA BEHR
> Assignee: BELUGA BEHR
> Priority: Minor
> Fix For: 4.0.0
>
> Attachments: HIVE-20257.1.patch, HIVE-20257.2.patch,
> HIVE-20257.3.patch, HIVE-20257.4.patch
>
>
> Various fixes to {{Hive.java}}
> * Use Log4J parameters in logging statements
> * Fix check styles
> * Make code more concise
> * Remove "log and throw" code
> * Replaced calls to deprecated code
> * Removed superfluous calls to {{toString}}
>
> "log and throw" is considered and anti-pattern. Only the highest level catch
> should be providing detailed logging otherwise we print the same stack trace
> to the logs several times and with different context (for example when an
> exception is wrapped, we get two different logging events).
>
> https://community.oracle.com/docs/DOC-983543#logAndThrow
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
