[ 
https://issues.apache.org/jira/browse/HIVE-18873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16598108#comment-16598108
 ] 

Vineet Garg commented on HIVE-18873:
------------------------------------

[~elserj] That query was just to demonstrate/reproduce the bug. This query is 
not part of test. Test has join queries for which Hive automatically generate 
is not null filter on join keys and passes it to storage handler (not sure why 
since Accumulo handler isn't able to handle it).

It was probably not caught earlier because hive.optimize.index.filter was off 
by default (therefore hive wasn't pushing the filter to storage handler). 
hive.optimize.index.filter was turned on by HIVE-12342 but then HIVE-15680 
caused hive to not push the filter to storage handler.
Basically it looks like this has been in the system for a while and is being 
exposed now due to these two jiras.

> Skipping predicate pushdown for MR silently at HiveInputFormat can cause 
> storage handlers to produce erroneous result
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-18873
>                 URL: https://issues.apache.org/jira/browse/HIVE-18873
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Ankit Singhal
>            Assignee: Ankit Singhal
>            Priority: Major
>         Attachments: HIVE-18873.2.patch, HIVE-18873.2_reattach.patch, 
> HIVE-18873.patch
>
>
> {code:java}
> // disable filter pushdown for mapreduce when there are more than one table 
> aliases,
>     // since we don't clone jobConf per alias
>     if (mrwork != null && mrwork.getAliases() != null && 
> mrwork.getAliases().size() > 1 &&
>       jobConf.get(ConfVars.HIVE_EXECUTION_ENGINE.varname).equals("mr")) {
>       return;
>     }
> {code}
> I believe this needs to be handled at OpProcFactory so that hive doesn't 
> believe that predicate is handled by storage handler.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to