[ 
https://issues.apache.org/jira/browse/HIVE-20515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607898#comment-16607898
 ] 

Hive QA commented on HIVE-20515:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12938852/HIVE-20515.2.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 14931 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/13656/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/13656/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-13656/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12938852 - PreCommit-HIVE-Build

> Empty query results when using results cache and query temp dir, results 
> cache dir in different filesystems
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-20515
>                 URL: https://issues.apache.org/jira/browse/HIVE-20515
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Jason Dere
>            Assignee: Jason Dere
>            Priority: Major
>         Attachments: HIVE-20515.1.patch, HIVE-20515.2.patch
>
>
> If the scratchdir for temporary query results and the results cache dir are 
> in different filesystems, moving the query from the temp directory to results 
> cache will fail.
> Looking at the moveResultsToCacheDirectory() logic in QueryResultsCache.java, 
> I see the following issues:
> - FileSystem.rename() is used, which only works if the files are on the same 
> filesystem. Need to use something like Hive.mvFile or something similar which 
> can work between different filesystems.
> - The return code from rename() was not checked which might possibly have 
> caught the error here. This may not be applicable if a different method from 
> FS.rename() is used in the proper fix.
> With some filesystems (noticed this with WASB), if FileSystem.rename() 
> returns false on failure rather than throwing an exception, then this results 
> in empty results showing up for the query because the return code was not 
> checked properly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to