[ 
https://issues.apache.org/jira/browse/HIVE-11174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14627043#comment-14627043
 ] 

Hive QA commented on HIVE-11174:
--------------------------------



{color:red}Overall{color}: -1 at least one tests failed

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12745306/HIVE-11174.1.patch

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 9189 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_transform_acid
org.apache.hive.hcatalog.hbase.TestPigHBaseStorageHandler.org.apache.hive.hcatalog.hbase.TestPigHBaseStorageHandler
{noformat}

Test results: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4611/testReport
Console output: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4611/console
Test logs: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-4611/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12745306 - PreCommit-HIVE-TRUNK-Build

> Hive does not treat floating point signed zeros as equal (-0.0 should equal 
> 0.0 according to IEEE floating point spec) 
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-11174
>                 URL: https://issues.apache.org/jira/browse/HIVE-11174
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 1.2.0
>            Reporter: Lenni Kuff
>            Assignee: Sergio Peña
>            Priority: Critical
>         Attachments: HIVE-11174.1.patch
>
>
> Hive does not treat floating point signed zeros as equal (-0.0 should equal 
> 0.0).  This is because Hive uses Double.compareTo(), which states 
> (http://docs.oracle.com/javase/7/docs/api/java/lang/Double.html#compareTo(java.lang.Double):
> bq. 0.0d is considered by this method to be greater than -0.0d
> The IEEE 754 floating point spec specifies that signed -0.0 and 0.0 should be 
> treated as equal. From the Wikipedia article 
> (https://en.wikipedia.org/wiki/Signed_zero#Comparisons):
> bq. negative zero and positive zero should compare as equal with the usual 
> (numerical) comparison operators
> Java's compareTo method is implemented to allow for ordering of object 
> instances (in a hash table or similar), but Hive should abide by the IEEE 
> spec.
> How to reproduce:
> {code}
> select 1 where 0.0=-0.0;
> Returns no results.
> select 1 where -0.0<0.0;
> Returns 1
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to