[ 
https://issues.apache.org/jira/browse/HIVE-20483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612364#comment-16612364
 ] 

Naveen Gangam commented on HIVE-20483:
--------------------------------------

[~akolb] Can you please provide some context on how these classes are being 
organized? it would make sense to categorize classes into 
1) hive-metastore-server 
2) hive-metastore-client and 
3) hive-metastore-common (classes that are used by both HMS server and HMS 
client) like the MetaStoreConf, *SpecProxy* etc.

In the patch, 
we are moving classes like IMetaStoreClient and MetaStoreClient to the common 
module. 
classes like FileUtils, HdfsUtils, MetaStoreUtils, ReplChangeManager, 
MetadataStore, MetaStoreFS to the common module. I havent looked at the usage 
of all the methods in these classes but they sound like they will be used by 
the HMS Server and should remain within the server module and not in the 
common. Are these classes somehow used by the client as well?


> Really move metastore common classes into metastore-common
> ----------------------------------------------------------
>
>                 Key: HIVE-20483
>                 URL: https://issues.apache.org/jira/browse/HIVE-20483
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Standalone Metastore
>    Affects Versions: 3.0.1, 4.0.0
>            Reporter: Alexander Kolbasov
>            Assignee: Alexander Kolbasov
>            Priority: Major
>         Attachments: HIVE-20483.01.patch, HIVE-20483.02.patch, 
> HIVE-20483.03.patch, HIVE-20483.04.patch, HIVE-20483.05.patch, 
> HIVE-20483.06.patch
>
>
>  HIVE-20388 patch was supposed to move a bunch of files from metastore-server 
> to metastore-common but for some reason it didn't happen, so now these files 
> should be moved.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to