[ 
https://issues.apache.org/jira/browse/HIVE-20551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16617708#comment-16617708
 ] 

Hive QA commented on HIVE-20551:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12939935/HIVE-20551.04.patch

{color:red}ERROR:{color} -1 due to build exiting with an error

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/13858/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/13858/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-13858/

Messages:
{noformat}
**** This message was trimmed, see log for full details ****
error: patch failed: 
ql/src/test/results/clientpositive/spark/vectorization_part_project.q.out:69
Falling back to three-way merge...
Applied patch to 
'ql/src/test/results/clientpositive/spark/vectorization_part_project.q.out' 
cleanly.
error: patch failed: 
ql/src/test/results/clientpositive/spark/vectorization_short_regress.q.out:1232
Falling back to three-way merge...
Applied patch to 
'ql/src/test/results/clientpositive/spark/vectorization_short_regress.q.out' 
cleanly.
error: patch failed: 
ql/src/test/results/clientpositive/spark/vectorized_case.q.out:314
Falling back to three-way merge...
Applied patch to 
'ql/src/test/results/clientpositive/spark/vectorized_case.q.out' cleanly.
error: patch failed: 
ql/src/test/results/clientpositive/spark/vectorized_mapjoin.q.out:102
Falling back to three-way merge...
Applied patch to 
'ql/src/test/results/clientpositive/spark/vectorized_mapjoin.q.out' cleanly.
error: patch failed: 
ql/src/test/results/clientpositive/spark/vectorized_ptf.q.out:154
Falling back to three-way merge...
Applied patch to 
'ql/src/test/results/clientpositive/spark/vectorized_ptf.q.out' cleanly.
error: patch failed: 
ql/src/test/results/clientpositive/spark/vectorized_timestamp_funcs.q.out:258
Falling back to three-way merge...
Applied patch to 
'ql/src/test/results/clientpositive/spark/vectorized_timestamp_funcs.q.out' 
cleanly.
error: patch failed: 
ql/src/test/results/clientpositive/spark/windowing.q.out:1856
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/spark/windowing.q.out' 
cleanly.
error: patch failed: 
ql/src/test/results/clientpositive/stat_estimate_drill.q.out:84
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/stat_estimate_drill.q.out' 
cleanly.
error: patch failed: 
ql/src/test/results/clientpositive/stat_estimate_related_col.q.out:89
Falling back to three-way merge...
Applied patch to 
'ql/src/test/results/clientpositive/stat_estimate_related_col.q.out' cleanly.
error: patch failed: 
ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out:324
Falling back to three-way merge...
Applied patch to 
'ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out' cleanly.
error: patch failed: 
ql/src/test/results/clientpositive/tez/acid_vectorization_original_tez.q.out:97
Falling back to three-way merge...
Applied patch to 
'ql/src/test/results/clientpositive/tez/acid_vectorization_original_tez.q.out' 
cleanly.
error: patch failed: 
ql/src/test/results/clientpositive/tez/explainanalyze_3.q.out:353
Falling back to three-way merge...
Applied patch to 
'ql/src/test/results/clientpositive/tez/explainanalyze_3.q.out' cleanly.
error: patch failed: 
ql/src/test/results/clientpositive/tez/explainanalyze_4.q.out:338
Falling back to three-way merge...
Applied patch to 
'ql/src/test/results/clientpositive/tez/explainanalyze_4.q.out' cleanly.
error: patch failed: 
ql/src/test/results/clientpositive/udtf_json_tuple.q.out:189
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/udtf_json_tuple.q.out' 
cleanly.
error: patch failed: 
ql/src/test/results/clientpositive/udtf_parse_url_tuple.q.out:208
Falling back to three-way merge...
Applied patch to 
'ql/src/test/results/clientpositive/udtf_parse_url_tuple.q.out' cleanly.
error: patch failed: ql/src/test/results/clientpositive/union_null.q.out:6
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/union_null.q.out' cleanly.
error: patch failed: ql/src/test/results/clientpositive/union_offcbo.q.out:281
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/union_offcbo.q.out' 
cleanly.
error: patch failed: ql/src/test/results/clientpositive/union_ppr.q.out:45
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/union_ppr.q.out' cleanly.
error: patch failed: 
ql/src/test/results/clientpositive/union_remove_6_subq.q.out:525
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/union_remove_6_subq.q.out' 
cleanly.
error: patch failed: 
ql/src/test/results/clientpositive/update_all_partitioned.q.out:53
Falling back to three-way merge...
Applied patch to 
'ql/src/test/results/clientpositive/update_all_partitioned.q.out' cleanly.
error: patch failed: 
ql/src/test/results/clientpositive/update_tmp_table.q.out:50
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/update_tmp_table.q.out' 
cleanly.
error: patch failed: 
ql/src/test/results/clientpositive/update_where_partitioned.q.out:53
Falling back to three-way merge...
Applied patch to 
'ql/src/test/results/clientpositive/update_where_partitioned.q.out' cleanly.
error: patch failed: 
ql/src/test/results/clientpositive/vector_case_when_2.q.out:235
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/vector_case_when_2.q.out' 
cleanly.
error: patch failed: ql/src/test/results/clientpositive/vector_coalesce.q.out:73
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/vector_coalesce.q.out' 
cleanly.
error: patch failed: 
ql/src/test/results/clientpositive/vector_coalesce_4.q.out:116
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/vector_coalesce_4.q.out' 
cleanly.
error: patch failed: 
ql/src/test/results/clientpositive/vector_data_types.q.out:169
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/vector_data_types.q.out' 
cleanly.
error: patch failed: ql/src/test/results/clientpositive/vector_date_1.q.out:58
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/vector_date_1.q.out' 
cleanly.
error: patch failed: 
ql/src/test/results/clientpositive/vector_decimal_1.q.out:132
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/vector_decimal_1.q.out' 
cleanly.
error: patch failed: 
ql/src/test/results/clientpositive/vector_decimal_10_0.q.out:121
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/vector_decimal_10_0.q.out' 
cleanly.
error: patch failed: 
ql/src/test/results/clientpositive/vector_decimal_3.q.out:48
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/vector_decimal_3.q.out' 
cleanly.
error: patch failed: 
ql/src/test/results/clientpositive/vector_decimal_4.q.out:56
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/vector_decimal_4.q.out' 
cleanly.
error: patch failed: 
ql/src/test/results/clientpositive/vector_decimal_5.q.out:56
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/vector_decimal_5.q.out' 
cleanly.
error: patch failed: 
ql/src/test/results/clientpositive/vector_decimal_6.q.out:194
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/vector_decimal_6.q.out' 
cleanly.
error: patch failed: 
ql/src/test/results/clientpositive/vector_decimal_precision.q.out:59
Falling back to three-way merge...
Applied patch to 
'ql/src/test/results/clientpositive/vector_decimal_precision.q.out' cleanly.
error: patch failed: 
ql/src/test/results/clientpositive/vector_left_outer_join2.q.out:65
Falling back to three-way merge...
Applied patch to 
'ql/src/test/results/clientpositive/vector_left_outer_join2.q.out' cleanly.
error: patch failed: 
ql/src/test/results/clientpositive/vector_outer_join1.q.out:120
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/vector_outer_join1.q.out' 
cleanly.
error: patch failed: 
ql/src/test/results/clientpositive/vector_outer_join2.q.out:94
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/vector_outer_join2.q.out' 
cleanly.
error: patch failed: 
ql/src/test/results/clientpositive/vector_outer_join3.q.out:94
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/vector_outer_join3.q.out' 
cleanly.
error: patch failed: 
ql/src/test/results/clientpositive/vector_outer_join4.q.out:130
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/vector_outer_join4.q.out' 
cleanly.
error: patch failed: 
ql/src/test/results/clientpositive/vector_string_concat.q.out:460
Falling back to three-way merge...
Applied patch to 
'ql/src/test/results/clientpositive/vector_string_concat.q.out' cleanly.
error: patch failed: 
ql/src/test/results/clientpositive/vectorization_13.q.out:290
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/vectorization_13.q.out' 
cleanly.
error: patch failed: 
ql/src/test/results/clientpositive/vectorization_7.q.out:195
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/vectorization_7.q.out' 
cleanly.
error: patch failed: 
ql/src/test/results/clientpositive/vectorization_limit.q.out:369
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/vectorization_limit.q.out' 
cleanly.
error: patch failed: 
ql/src/test/results/clientpositive/vectorization_part_project.q.out:64
Falling back to three-way merge...
Applied patch to 
'ql/src/test/results/clientpositive/vectorization_part_project.q.out' cleanly.
Falling back to three-way merge...
Applied patch to 
'ql/src/test/results/clientpositive/vectorized_join46_mr.q.out' cleanly.
error: patch failed: 
ql/src/test/results/clientpositive/vectorized_timestamp_funcs.q.out:253
Falling back to three-way merge...
Applied patch to 
'ql/src/test/results/clientpositive/vectorized_timestamp_funcs.q.out' cleanly.
error: patch failed: ql/src/test/results/clientpositive/windowing_gby2.q.out:79
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/windowing_gby2.q.out' 
cleanly.
error: patch failed: 
ql/src/test/results/clientpositive/windowing_navfn.q.out:731
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/windowing_navfn.q.out' 
cleanly.
error: patch failed: 
ql/src/test/results/clientpositive/windowing_order_null.q.out:80
Falling back to three-way merge...
Applied patch to 
'ql/src/test/results/clientpositive/windowing_order_null.q.out' cleanly.
error: patch failed: 
ql/src/test/results/clientpositive/windowing_streaming.q.out:83
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/windowing_streaming.q.out' 
cleanly.
error: patch failed: 
ql/src/test/results/clientpositive/windowing_windowspec3.q.out:86
Falling back to three-way merge...
Applied patch to 
'ql/src/test/results/clientpositive/windowing_windowspec3.q.out' cleanly.
error: patch failed: 
serde/src/test/org/apache/hadoop/hive/serde2/VerifyFast.java:599
Falling back to three-way merge...
Applied patch to 'serde/src/test/org/apache/hadoop/hive/serde2/VerifyFast.java' 
cleanly.
error: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/common/StatsSetupConst.java:
 does not exist in index
error: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ColumnType.java:
 does not exist in index
error: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/FileMetadataHandler.java:
 does not exist in index
error: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java:
 does not exist in index
error: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java:
 does not exist in index
error: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreFS.java:
 does not exist in index
error: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetadataStore.java:
 does not exist in index
error: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetastoreTaskThread.java:
 does not exist in index
error: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PartitionExpressionProxy.java:
 does not exist in index
error: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ReplChangeManager.java:
 does not exist in index
error: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java:
 does not exist in index
error: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/TableIterable.java:
 does not exist in index
error: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/Warehouse.java:
 does not exist in index
error: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
 does not exist in index
error: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/conf/TimeValidator.java:
 does not exist in index
error: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/partition/spec/CompositePartitionSpecProxy.java:
 does not exist in index
error: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/partition/spec/PartitionListComposingSpecProxy.java:
 does not exist in index
error: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/partition/spec/PartitionSpecProxy.java:
 does not exist in index
error: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/partition/spec/PartitionSpecWithSharedSDProxy.java:
 does not exist in index
error: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/security/DelegationTokenIdentifier.java:
 does not exist in index
error: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/security/DelegationTokenSecretManager.java:
 does not exist in index
error: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/security/DelegationTokenSelector.java:
 does not exist in index
error: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/security/HadoopThriftAuthBridge.java:
 does not exist in index
error: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/security/HadoopThriftAuthBridge23.java:
 does not exist in index
error: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/FileUtils.java:
 does not exist in index
error: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/HdfsUtils.java:
 does not exist in index
error: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java:
 does not exist in index
error: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/SecurityUtils.java:
 does not exist in index
error: patch failed: 
storage-api/src/test/org/apache/hadoop/hive/ql/exec/vector/TestTimestampColumnVector.java:38
Falling back to three-way merge...
Applied patch to 
'storage-api/src/test/org/apache/hadoop/hive/ql/exec/vector/TestTimestampColumnVector.java'
 cleanly.
error: patch failed: streaming/pom.xml:91
Falling back to three-way merge...
Applied patch to 'streaming/pom.xml' cleanly.
error: patch failed: testutils/ptest2/conf/deployed/master-mr2.properties:182
Falling back to three-way merge...
Applied patch to 'testutils/ptest2/conf/deployed/master-mr2.properties' cleanly.
fatal: git apply: bad git-diff - inconsistent old filename on line 156499
fatal: git diff header lacks filename information when removing 2 leading 
pathname components (line 5)
The patch does not appear to apply with p0, p1, or p2
+ result=1
+ '[' 1 -ne 0 ']'
+ rm -rf yetus_PreCommit-HIVE-Build-13858
+ exit 1
'
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12939935 - PreCommit-HIVE-Build

> Create PreparedStatement query dynamically when IN clause is used
> -----------------------------------------------------------------
>
>                 Key: HIVE-20551
>                 URL: https://issues.apache.org/jira/browse/HIVE-20551
>             Project: Hive
>          Issue Type: Bug
>          Components: Hive
>            Reporter: Laszlo Pinter
>            Assignee: Laszlo Pinter
>            Priority: Major
>         Attachments: HIVE-20551.01.patch, HIVE-20551.02.patch, 
> HIVE-20551.03.patch, HIVE-20551.04.patch
>
>
> In the MetaStoreDirectSql class when IN clause is used, the query statement 
> is created via string concatenation.
> Since JDBC API allows only one literal for one “?” parameter, 
> PreparedStatement doesn’t work for IN clause queries. To create the 
> PreparedStatement query dynamically based on the size of the elements in IN 
> clause, the makeParams() should be used instead of concatenation. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to