[ 
https://issues.apache.org/jira/browse/HIVE-19950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16621348#comment-16621348
 ] 

Hive QA commented on HIVE-19950:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12928594/patch.patch

{color:red}ERROR:{color} -1 due to build exiting with an error

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/13916/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/13916/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-13916/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit 
status 1 and output '+ date '+%Y-%m-%d %T.%3N'
2018-09-20 00:31:21.054
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export 
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ 
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-13916/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2018-09-20 00:31:21.058
+ cd apache-github-source-source
+ git fetch origin
+ git reset --hard HEAD
HEAD is now at 487714a HIVE-19166: TestMiniLlapLocalCliDriver sysdb failure 
(Daniel Dai, reviewed by Vaibhav Gumashta)
+ git clean -f -d
Removing standalone-metastore/metastore-server/src/gen/
+ git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
+ git reset --hard origin/master
HEAD is now at 487714a HIVE-19166: TestMiniLlapLocalCliDriver sysdb failure 
(Daniel Dai, reviewed by Vaibhav Gumashta)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2018-09-20 00:31:21.775
+ rm -rf ../yetus_PreCommit-HIVE-Build-13916
+ mkdir ../yetus_PreCommit-HIVE-Build-13916
+ git gc
+ cp -R . ../yetus_PreCommit-HIVE-Build-13916
+ mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-13916/yetus
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh 
/data/hiveptest/working/scratch/build.patch
error: 
a/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
 does not exist in index
error: 
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
 does not exist in index
error: src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java: does 
not exist in index
The patch does not appear to apply with p0, p1, or p2
+ result=1
+ '[' 1 -ne 0 ']'
+ rm -rf yetus_PreCommit-HIVE-Build-13916
+ exit 1
'
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12928594 - PreCommit-HIVE-Build

> Hive ACID NOT LOCK LockComponent Correctly
> ------------------------------------------
>
>                 Key: HIVE-19950
>                 URL: https://issues.apache.org/jira/browse/HIVE-19950
>             Project: Hive
>          Issue Type: Bug
>          Components: Transactions
>    Affects Versions: 2.3.2
>            Reporter: nickSoul
>            Priority: Blocker
>         Attachments: patch.patch
>
>
> Hi,
>     When using Streaming Mutation recently, I found LockComponents were not 
> locked correctly by current transaction.  Below is my test case:
> Step1: Begin a transaction with transactionId 126, and the transaction locks 
> a table. Then hangs the transaction. The lock information were correctly 
> restored in mariaDB.
> {code:sql}
> MariaDB [hive]> select 
> HL_LOCK_EXT_ID,HL_LOCK_INT_ID,HL_TXNID,HL_DB,HL_TABLE,HL_PARTITION,HL_LOCK_STATE,HL_LOCK_TYPE,HL_ACQUIRED_AT,HL_BLOCKEDBY_EXT_ID,HL_BLOCKEDBY_INT_ID
>  from HIVE_LOCKS;
> {code}
> | HL_LOCK_EXT_ID | HL_LOCK_INT_ID | HL_TXNID | HL_DB | HL_TABLE | 
> HL_PARTITION | HL_LOCK_STATE | HL_LOCK_TYPE | HL_ACQUIRED_AT | 
> HL_BLOCKEDBY_EXT_ID | HL_BLOCKEDBY_INT_ID |
> | 384 | 1 | 126 | test_acid | acid_test | NULL | a | w | 1529512857000 | NULL 
> | NULL |
>  
> Step2: Begin the other transaction with a transactionId 127 before previous 
> transaction 126 finished. Transaction 127 tries to lock the same table too, 
> but failed at first attempt. The lock information were correctly restored in 
> mariaDB, Lock 385 was blocked by Lock 384. 
> {code:sql}
> MariaDB [hive]> select 
> HL_LOCK_EXT_ID,HL_LOCK_INT_ID,HL_TXNID,HL_DB,HL_TABLE,HL_PARTITION,HL_LOCK_STATE,HL_LOCK_TYPE,HL_ACQUIRED_AT,HL_BLOCKEDBY_EXT_ID,HL_BLOCKEDBY_INT_ID
>  from HIVE_LOCKS;{code}
> | HL_LOCK_EXT_ID | HL_LOCK_INT_ID | HL_TXNID | HL_DB | HL_TABLE | 
> HL_PARTITION | HL_LOCK_STATE | HL_LOCK_TYPE | HL_ACQUIRED_AT | 
> HL_BLOCKEDBY_EXT_ID | HL_BLOCKEDBY_INT_ID |
> | 384 | 1 | 126 | test_acid | acid_test | NULL | a | w | 1529512857000 | NULL 
> | NULL |
> | 385 | 1 | 127 | test_acid | acid_test | NULL | w | w | NULL | 384 | 1 |
> Step3: Then transaction 127 tries to lock the table for a second retry after 
> 30s with another lockId: 386, this time it successfully locked the table,  
> whereas transaction 126 is still holding the lock. Lock informations in 
> MetaStore DB:
> {code:sql}
> MariaDB [hive]> select 
> HL_LOCK_EXT_ID,HL_LOCK_INT_ID,HL_TXNID,HL_DB,HL_TABLE,HL_PARTITION,HL_LOCK_STATE,HL_LOCK_TYPE,HL_ACQUIRED_AT,HL_BLOCKEDBY_EXT_ID,HL_BLOCKEDBY_INT_ID
>  from HIVE_LOCKS; {code}
> | HL_LOCK_EXT_ID | HL_LOCK_INT_ID | HL_TXNID | HL_DB | HL_TABLE | 
> HL_PARTITION | HL_LOCK_STATE | HL_LOCK_TYPE | HL_ACQUIRED_AT | 
> HL_BLOCKEDBY_EXT_ID | HL_BLOCKEDBY_INT_ID | 
> |384| 1 |126| test_acid | acid_test | NULL | a | w | 1529512857000 | NULL | 
> NULL | 
> |385| 1 |127| test_acid |acid_test| NULL| w | w| NULL|384 | 1 | 
> |386| 1 |127| test_acid | acid_test | NULL | a | w | 1529513069000 | NULL | 
> NULL | 
>  
>     After going through the code.  I found it dosen't care about other 
> transaction's lock on the LockComponents in second retry.
>     I wonder if i use it in a wrong way, or misunderstand sth about ACID in 
> hive.
>                                                                               
>                                                      Thanks



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to