[ 
https://issues.apache.org/jira/browse/HIVE-20542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16621975#comment-16621975
 ] 

Ashutosh Bapat commented on HIVE-20542:
---------------------------------------

There are two issues
1. For every event, DbNotificationListner adds an event in the metastore using 
addNotificationLog() method. When the event has no database associated with it 
e.g. an open transaction event, this method inserts a row with dbname set to 
'null' instead of NULL. The fix is not to list DB_NAME column when inserting 
such events. The dbname is set to 'null' because of we try to use a null String 
object in concatenation. This seems to be an unintentional side-effect.

2. When reporting the estimated number of events in 
ObjectStore::getNotificationEventsCount() the query has equality condition on 
db_name and catname columns. The condition filters out all the events with NULL 
dbname and NULL catname, i.e. the events related to transactions. These events 
are important for replication since they need to be replicated to provide 
consistent data to the readers running in parallel to the load operation. The 
fix is to add a "OR is NULL clause on the DB_NAME and CAT_NAME".

Attached patch fixes both these issues.

> Incremental REPL DUMP progress information log message is incorrect.
> --------------------------------------------------------------------
>
>                 Key: HIVE-20542
>                 URL: https://issues.apache.org/jira/browse/HIVE-20542
>             Project: Hive
>          Issue Type: Bug
>          Components: repl
>    Affects Versions: 4.0.0, 3.2.0
>            Reporter: Sankar Hariappan
>            Assignee: Ashutosh Bapat
>            Priority: Minor
>              Labels: DR, Replication
>
> Incremental REPL DUMP have the progress information logged as 
> "eventsDumpProgress":"49/0".
> It should actually log the estimated number of events are denominator but it 
> is coming as 0 always.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to