[ 
https://issues.apache.org/jira/browse/HIVE-20635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16639013#comment-16639013
 ] 

Eugene Koifman commented on HIVE-20635:
---------------------------------------

A nit: {{      LOG.info("findOriginalMinMaxKeys(): " + keyIntervalTmp);}} is 
only logged {{if (minRowId >= maxRowId) {}}

would be better to log it always

otherwise LGTM

> VectorizedOrcAcidRowBatchReader doesn't filter delete events for original 
> files
> -------------------------------------------------------------------------------
>
>                 Key: HIVE-20635
>                 URL: https://issues.apache.org/jira/browse/HIVE-20635
>             Project: Hive
>          Issue Type: Improvement
>          Components: Transactions
>    Affects Versions: 3.0.0
>            Reporter: Eugene Koifman
>            Assignee: Saurabh Seth
>            Priority: Major
>         Attachments: HIVE-20635.2.patch, HIVE-20635.patch
>
>
> this is a followup to HIVE-16812 which adds support for delete event 
> filtering for splits from native acid files
> need to add the same for {{OrcSplit.isOriginal()}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to