[ 
https://issues.apache.org/jira/browse/HIVE-11139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632655#comment-14632655
 ] 

Prasanth Jayachandran commented on HIVE-11139:
----------------------------------------------

Hi [~szehon] and [~jxiang]..

I am working on HIVE-11304 and in the process noticed that this jira added a 
new RFA NoDeleteRollingFileAppender. I am wondering what is the purpose of it? 
If I understand correctly, it doesn't delete the old rollover files under any 
condition. If that's the case, similar behaviour can be obtained by setting the 
maxBackupIndex to negative value or 0 by default in log4j.properties file. 
http://grepcode.com/file/repo1.maven.org/maven2/log4j/log4j/1.2.17/org/apache/log4j/RollingFileAppender.java#141
The delete codepath gets triggered only when maxBackupIndex is > 0 which should 
get you the same behaviour of not deleting at all.
If it serves a different purpose, can you guys please explain it? Its hard to 
port such custom appenders to log4j2, as the APIs are not compatible.

> Emit more lineage information
> -----------------------------
>
>                 Key: HIVE-11139
>                 URL: https://issues.apache.org/jira/browse/HIVE-11139
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>             Fix For: 1.3.0, 2.0.0
>
>         Attachments: HIVE-11139.1.patch, HIVE-11139.2.patch, 
> HIVE-11139.3.patch
>
>
> HIVE-1131 emits some column lineage info. But it doesn't support INSERT 
> statements, or CTAS statements. It doesn't emit the predicate information 
> either.
> We can enhance and use the dependency information created in HIVE-1131, 
> generate more complete lineage info.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to