[ 
https://issues.apache.org/jira/browse/HIVE-20731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16647262#comment-16647262
 ] 

Thejas M Nair commented on HIVE-20731:
--------------------------------------

Can you also add a negative test ? Maybe set the permissions for file like this 
negative test - clientnegative/authorization_uri_load_data.q

 

Also, some nits -
 * In addPropertyReadEntry method signature, instead of HashSet<ReadEntity> 
inputs, use Set<ReadEntity> inputs
 * "only JavaKeyStoreProvider are" -> "only JavaKeyStoreProvider is " 

 

> keystore file in JdbcStorageHandler should be authorized
> --------------------------------------------------------
>
>                 Key: HIVE-20731
>                 URL: https://issues.apache.org/jira/browse/HIVE-20731
>             Project: Hive
>          Issue Type: Improvement
>          Components: StorageHandler
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>            Priority: Major
>         Attachments: HIVE-20731.1.patch
>
>
> The keystore file introduced in HIVE-20651 shall be authorized with 
> configured authorizer. Otherwise any user knows the keystore file location 
> can access the password.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to