[ 
https://issues.apache.org/jira/browse/HIVE-20607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662935#comment-16662935
 ] 

Hive QA commented on HIVE-20607:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12945453/HIVE-20607.01-branch-3.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 108 failed/errored test(s), 14453 tests 
executed
*Failed tests:*
{noformat}
TestAddPartitions - did not produce a TEST-*.xml file (likely timed out) 
(batchId=228)
TestAddPartitionsFromPartSpec - did not produce a TEST-*.xml file (likely timed 
out) (batchId=230)
TestAdminUser - did not produce a TEST-*.xml file (likely timed out) 
(batchId=236)
TestAggregateStatsCache - did not produce a TEST-*.xml file (likely timed out) 
(batchId=230)
TestAlterPartitions - did not produce a TEST-*.xml file (likely timed out) 
(batchId=230)
TestAlterTableMetadata - did not produce a TEST-*.xml file (likely timed out) 
(batchId=252)
TestAppendPartitions - did not produce a TEST-*.xml file (likely timed out) 
(batchId=230)
TestAutoPurgeTables - did not produce a TEST-*.xml file (likely timed out) 
(batchId=252)
TestBeeLineDriver - did not produce a TEST-*.xml file (likely timed out) 
(batchId=273)
TestCachedStore - did not produce a TEST-*.xml file (likely timed out) 
(batchId=236)
TestCatalogCaching - did not produce a TEST-*.xml file (likely timed out) 
(batchId=236)
TestCatalogNonDefaultClient - did not produce a TEST-*.xml file (likely timed 
out) (batchId=228)
TestCatalogNonDefaultSvr - did not produce a TEST-*.xml file (likely timed out) 
(batchId=236)
TestCatalogOldClient - did not produce a TEST-*.xml file (likely timed out) 
(batchId=228)
TestCatalogs - did not produce a TEST-*.xml file (likely timed out) 
(batchId=230)
TestCheckConstraint - did not produce a TEST-*.xml file (likely timed out) 
(batchId=228)
TestDataSourceProviderFactory - did not produce a TEST-*.xml file (likely timed 
out) (batchId=238)
TestDatabases - did not produce a TEST-*.xml file (likely timed out) 
(batchId=230)
TestDeadline - did not produce a TEST-*.xml file (likely timed out) 
(batchId=236)
TestDefaultConstraint - did not produce a TEST-*.xml file (likely timed out) 
(batchId=230)
TestDropPartitions - did not produce a TEST-*.xml file (likely timed out) 
(batchId=228)
TestDummy - did not produce a TEST-*.xml file (likely timed out) (batchId=273)
TestEmbeddedHiveMetaStore - did not produce a TEST-*.xml file (likely timed 
out) (batchId=231)
TestExchangePartitions - did not produce a TEST-*.xml file (likely timed out) 
(batchId=230)
TestFMSketchSerialization - did not produce a TEST-*.xml file (likely timed 
out) (batchId=238)
TestFilterHooks - did not produce a TEST-*.xml file (likely timed out) 
(batchId=228)
TestForeignKey - did not produce a TEST-*.xml file (likely timed out) 
(batchId=230)
TestFunctions - did not produce a TEST-*.xml file (likely timed out) 
(batchId=228)
TestGetPartitions - did not produce a TEST-*.xml file (likely timed out) 
(batchId=228)
TestGetPartitionsUsingProjectionAndFilterSpecs - did not produce a TEST-*.xml 
file (likely timed out) (batchId=230)
TestGetTableMeta - did not produce a TEST-*.xml file (likely timed out) 
(batchId=228)
TestHLLNoBias - did not produce a TEST-*.xml file (likely timed out) 
(batchId=238)
TestHLLSerialization - did not produce a TEST-*.xml file (likely timed out) 
(batchId=238)
TestHdfsUtils - did not produce a TEST-*.xml file (likely timed out) 
(batchId=236)
TestHiveAlterHandler - did not produce a TEST-*.xml file (likely timed out) 
(batchId=228)
TestHiveMetaStoreGetMetaConf - did not produce a TEST-*.xml file (likely timed 
out) (batchId=238)
TestHiveMetaStorePartitionSpecs - did not produce a TEST-*.xml file (likely 
timed out) (batchId=230)
TestHiveMetaStoreSchemaMethods - did not produce a TEST-*.xml file (likely 
timed out) (batchId=236)
TestHiveMetaStoreTimeout - did not produce a TEST-*.xml file (likely timed out) 
(batchId=238)
TestHiveMetaStoreTxns - did not produce a TEST-*.xml file (likely timed out) 
(batchId=238)
TestHiveMetaStoreWithEnvironmentContext - did not produce a TEST-*.xml file 
(likely timed out) (batchId=233)
TestHiveMetastoreCli - did not produce a TEST-*.xml file (likely timed out) 
(batchId=228)
TestHyperLogLog - did not produce a TEST-*.xml file (likely timed out) 
(batchId=238)
TestHyperLogLogDense - did not produce a TEST-*.xml file (likely timed out) 
(batchId=238)
TestHyperLogLogMerge - did not produce a TEST-*.xml file (likely timed out) 
(batchId=238)
TestHyperLogLogSparse - did not produce a TEST-*.xml file (likely timed out) 
(batchId=238)
TestJSONMessageDeserializer - did not produce a TEST-*.xml file (likely timed 
out) (batchId=236)
TestListPartitions - did not produce a TEST-*.xml file (likely timed out) 
(batchId=228)
TestLocationQueries - did not produce a TEST-*.xml file (likely timed out) 
(batchId=252)
TestLockRequestBuilder - did not produce a TEST-*.xml file (likely timed out) 
(batchId=228)
TestMarkPartition - did not produce a TEST-*.xml file (likely timed out) 
(batchId=236)
TestMarkPartitionRemote - did not produce a TEST-*.xml file (likely timed out) 
(batchId=238)
TestMetaStoreConnectionUrlHook - did not produce a TEST-*.xml file (likely 
timed out) (batchId=230)
TestMetaStoreEndFunctionListener - did not produce a TEST-*.xml file (likely 
timed out) (batchId=230)
TestMetaStoreEventListener - did not produce a TEST-*.xml file (likely timed 
out) (batchId=234)
TestMetaStoreEventListenerOnlyOnCommit - did not produce a TEST-*.xml file 
(likely timed out) (batchId=236)
TestMetaStoreEventListenerWithOldConf - did not produce a TEST-*.xml file 
(likely timed out) (batchId=238)
TestMetaStoreInitListener - did not produce a TEST-*.xml file (likely timed 
out) (batchId=236)
TestMetaStoreListenersError - did not produce a TEST-*.xml file (likely timed 
out) (batchId=236)
TestMetaStoreSchemaFactory - did not produce a TEST-*.xml file (likely timed 
out) (batchId=236)
TestMetaStoreSchemaInfo - did not produce a TEST-*.xml file (likely timed out) 
(batchId=236)
TestMetaStoreServerUtils - did not produce a TEST-*.xml file (likely timed out) 
(batchId=236)
TestMetastoreConf - did not produce a TEST-*.xml file (likely timed out) 
(batchId=230)
TestMetastoreSchemaTool - did not produce a TEST-*.xml file (likely timed out) 
(batchId=236)
TestMetrics - did not produce a TEST-*.xml file (likely timed out) (batchId=230)
TestMiniDruidCliDriver - did not produce a TEST-*.xml file (likely timed out) 
(batchId=273)
TestMiniDruidKafkaCliDriver - did not produce a TEST-*.xml file (likely timed 
out) (batchId=273)
TestNotNullConstraint - did not produce a TEST-*.xml file (likely timed out) 
(batchId=230)
TestObjectStore - did not produce a TEST-*.xml file (likely timed out) 
(batchId=238)
TestObjectStoreInitRetry - did not produce a TEST-*.xml file (likely timed out) 
(batchId=236)
TestObjectStoreSchemaMethods - did not produce a TEST-*.xml file (likely timed 
out) (batchId=238)
TestOldSchema - did not produce a TEST-*.xml file (likely timed out) 
(batchId=236)
TestPartitionNameWhitelistValidation - did not produce a TEST-*.xml file 
(likely timed out) (batchId=230)
TestPartitionProjectionEvaluator - did not produce a TEST-*.xml file (likely 
timed out) (batchId=238)
TestPreUpgradeTool - did not produce a TEST-*.xml file (likely timed out) 
(batchId=331)
TestPrimaryKey - did not produce a TEST-*.xml file (likely timed out) 
(batchId=230)
TestRawStoreProxy - did not produce a TEST-*.xml file (likely timed out) 
(batchId=228)
TestRemoteHiveMetaStore - did not produce a TEST-*.xml file (likely timed out) 
(batchId=232)
TestRemoteHiveMetaStoreIpAddress - did not produce a TEST-*.xml file (likely 
timed out) (batchId=226)
TestRemoteUGIHiveMetaStoreIpAddress - did not produce a TEST-*.xml file (likely 
timed out) (batchId=235)
TestReplicationScenariosAcidTables - did not produce a TEST-*.xml file (likely 
timed out) (batchId=252)
TestRetriesInRetryingHMSHandler - did not produce a TEST-*.xml file (likely 
timed out) (batchId=238)
TestRetryingHMSHandler - did not produce a TEST-*.xml file (likely timed out) 
(batchId=236)
TestRuntimeStats - did not produce a TEST-*.xml file (likely timed out) 
(batchId=228)
TestSchemaToolForMetastore - did not produce a TEST-*.xml file (likely timed 
out) (batchId=236)
TestSemanticAnalyzerHookLoading - did not produce a TEST-*.xml file (likely 
timed out) (batchId=252)
TestSetUGIOnBothClientServer - did not produce a TEST-*.xml file (likely timed 
out) (batchId=229)
TestSetUGIOnOnlyClient - did not produce a TEST-*.xml file (likely timed out) 
(batchId=227)
TestSetUGIOnOnlyServer - did not produce a TEST-*.xml file (likely timed out) 
(batchId=237)
TestSparkStatistics - did not produce a TEST-*.xml file (likely timed out) 
(batchId=252)
TestSparseEncodeHash - did not produce a TEST-*.xml file (likely timed out) 
(batchId=238)
TestStats - did not produce a TEST-*.xml file (likely timed out) (batchId=230)
TestStatsSetupConst - did not produce a TEST-*.xml file (likely timed out) 
(batchId=238)
TestTableIterable - did not produce a TEST-*.xml file (likely timed out) 
(batchId=238)
TestTablesCreateDropAlterTruncate - did not produce a TEST-*.xml file (likely 
timed out) (batchId=228)
TestTablesGetExists - did not produce a TEST-*.xml file (likely timed out) 
(batchId=230)
TestTablesList - did not produce a TEST-*.xml file (likely timed out) 
(batchId=228)
TestTezPerfCliDriver - did not produce a TEST-*.xml file (likely timed out) 
(batchId=273)
TestTxnHandlerNegative - did not produce a TEST-*.xml file (likely timed out) 
(batchId=228)
TestTxnUtils - did not produce a TEST-*.xml file (likely timed out) 
(batchId=228)
TestUniqueConstraint - did not produce a TEST-*.xml file (likely timed out) 
(batchId=228)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[mm_all] (batchId=71)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[mm_all] 
(batchId=154)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[external_jdbc_auth]
 (batchId=161)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb] 
(batchId=166)
org.apache.hadoop.hive.ql.TestWarehouseExternalDir.testManagedPaths 
(batchId=250)
org.apache.hive.service.TestHS2ImpersonationWithRemoteMS.testImpersonation 
(batchId=258)
org.apache.hive.spark.client.rpc.TestRpc.testServerPort (batchId=325)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/14628/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14628/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14628/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 108 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12945453 - PreCommit-HIVE-Build

> TxnHandler should use PreparedStatement to execute direct SQL queries.
> ----------------------------------------------------------------------
>
>                 Key: HIVE-20607
>                 URL: https://issues.apache.org/jira/browse/HIVE-20607
>             Project: Hive
>          Issue Type: Bug
>          Components: Standalone Metastore, Transactions
>    Affects Versions: 4.0.0
>            Reporter: Sankar Hariappan
>            Assignee: Sankar Hariappan
>            Priority: Major
>              Labels: ACID, pull-request-available
>             Fix For: 4.0.0
>
>         Attachments: HIVE-20607.01-branch-3.patch, HIVE-20607.01.patch
>
>
> TxnHandler uses direct SQL queries to operate on Txn related databases/tables 
> in Hive metastore RDBMS.
> Most of the methods are direct calls from Metastore api which should be 
> directly append input string arguments to the SQL string.
> Need to use parameterised PreparedStatement object to set these arguments.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to