[
https://issues.apache.org/jira/browse/HIVE-20855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16674160#comment-16674160
]
Hive QA commented on HIVE-20855:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
31s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
17s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m
6s{color} | {color:blue} standalone-metastore/metastore-server in master has
185 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
27s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
10s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
18s{color} | {color:red} hcatalog-unit in the patch failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
9s{color} | {color:red} standalone-metastore/metastore-server generated 2 new +
183 unchanged - 2 fixed = 185 total (was 185) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
10s{color} | {color:green} hcatalog-unit in the patch passed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
18s{color} | {color:green} standalone-metastore_metastore-server generated 0
new + 33 unchanged - 15 fixed = 33 total (was 48) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
13s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 14m 41s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:standalone-metastore/metastore-server |
| | Null pointer dereference of partNames in
org.apache.hadoop.hive.metastore.ObjectStore.getAggrStatsFor(String, String,
String, List, List, String) Dereferenced at ObjectStore.java:in
org.apache.hadoop.hive.metastore.ObjectStore.getAggrStatsFor(String, String,
String, List, List, String) Dereferenced at ObjectStore.java:[line 9067] |
| | Load of known null value in
org.apache.hadoop.hive.metastore.ObjectStore.getAggrStatsFor(String, String,
String, List, List, String) At ObjectStore.java:in
org.apache.hadoop.hive.metastore.ObjectStore.getAggrStatsFor(String, String,
String, List, List, String) At ObjectStore.java:[line 9067] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-14728/dev-support/hive-personality.sh
|
| git revision | master / ae1eb15 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| mvninstall |
http://104.198.109.242/logs//PreCommit-HIVE-Build-14728/yetus/patch-mvninstall-itests_hcatalog-unit.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-14728/yetus/new-findbugs-standalone-metastore_metastore-server.html
|
| modules | C: itests/hcatalog-unit standalone-metastore/metastore-server U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-14728/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> Clean up checkstyle & other warnings for CachedStore
> ----------------------------------------------------
>
> Key: HIVE-20855
> URL: https://issues.apache.org/jira/browse/HIVE-20855
> Project: Hive
> Issue Type: Improvement
> Reporter: Lars Francke
> Assignee: Lars Francke
> Priority: Minor
> Attachments: HIVE-20855.1.patch, HIVE-20855.2.patch
>
>
> While documenting the CachedStore in the Wiki I found a bunch of warnings,
> inconsistencies etc. in CachedStore, RawStore and a few other related classes.
> This is a patch that cleans them up. It's almost whitespace-only.
> It does not contain semantic code changes, it does contain two or three
> deprecations in favor of renamed methods or fields.
> This is going to be boring to review so according to the bylaws I'll ask for
> feedback on the mailing list and will commit after a week or so.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
