[ 
https://issues.apache.org/jira/browse/HIVE-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14637596#comment-14637596
 ] 

Prasanth Jayachandran commented on HIVE-11304:
----------------------------------------------

[~thejas] Can you take a look at the changes to LogDivertAppender? I am not 
sure of the purpose of doAppend() method that was there in the initial 
implementation. In my understanding, it seems to be checking for any changes in 
verbosity before writing every log line. If the verbosity changes then it 
switches to a different layout. If thats the case, under what circumstances can 
the verbosity change. Is there a test case to verify changing verbosity?

> Migrate to Log4j2 from Log4j 1.x
> --------------------------------
>
>                 Key: HIVE-11304
>                 URL: https://issues.apache.org/jira/browse/HIVE-11304
>             Project: Hive
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Prasanth Jayachandran
>            Assignee: Prasanth Jayachandran
>         Attachments: HIVE-11304.2.patch, HIVE-11304.patch
>
>
> Log4J2 has some great benefits and can benefit hive significantly. Some 
> notable features include
> 1) Performance (parametrized logging, performance when logging is disabled 
> etc.) More details can be found here 
> https://logging.apache.org/log4j/2.x/performance.html
> 2) RoutingAppender - Route logs to different log files based on MDC context 
> (useful for HS2, LLAP etc.)
> 3) Asynchronous logging
> This is an umbrella jira to track changes related to Log4j2 migration.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to