[
https://issues.apache.org/jira/browse/HIVE-20807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678131#comment-16678131
]
Hive QA commented on HIVE-20807:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12947142/HIVE-20807.06.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 15526 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/14788/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14788/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14788/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12947142 - PreCommit-HIVE-Build
> Refactor LlapStatusServiceDriver
> --------------------------------
>
> Key: HIVE-20807
> URL: https://issues.apache.org/jira/browse/HIVE-20807
> Project: Hive
> Issue Type: Improvement
> Components: Hive
> Affects Versions: 4.0.0
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-20807.01.patch, HIVE-20807.02.patch,
> HIVE-20807.03.patch, HIVE-20807.04.patch, HIVE-20807.05.patch,
> HIVE-20807.06.patch
>
>
> LlapStatusServiceDriver is the class used to determine if LLAP has started.
> The following problems should be solved by refactoring:
> 1. The main class is more than 800 lines long,should be cut into multiple
> smaller classes.
> 2. The current design makes it extremely hard to write unit tests.
> 3. There are some overcomplicated, over-engineered parts of the code.
> 4. Most of the code is under org.apache.hadoop.hive.llap.cli, but some parts
> are under org.apache.hadoop.hive.llap.cli.status. The whole program could be
> moved to the latter.
> 5. LlapStatusHelpers serves as a class for holding classes, which doesn't
> make much sense.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
