[ 
https://issues.apache.org/jira/browse/HIVE-20893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682121#comment-16682121
 ] 

slim bouguerra commented on HIVE-20893:
---------------------------------------

I did test this locally and added some tests for float case. [^HIVE-20893.patch]

Will run some Benchmark soon on our internal Cluster while tests will run on 
the patch.

> BloomK Filter probing method is not thread safe
> -----------------------------------------------
>
>                 Key: HIVE-20893
>                 URL: https://issues.apache.org/jira/browse/HIVE-20893
>             Project: Hive
>          Issue Type: Bug
>          Components: storage-api
>            Reporter: slim bouguerra
>            Assignee: slim bouguerra
>            Priority: Major
>         Attachments: HIVE-20893.WIP.patch, HIVE-20893.patch
>
>
> As far i can tell this is not an issue for Hive yet (most of the usage of 
> probing seems to be done by one thread at a time) but it is an issue of other 
> users like Druid as per the following 
> issue.[https://github.com/apache/incubator-druid/issues/6546]
> The fix is proposed by the author of 
> [https://github.com/apache/incubator-druid/pull/6584] is to make couple of 
> local fields as ThreadLocals.
> Idea looks good to me and doesn't have any perf drawbacks.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to