[ https://issues.apache.org/jira/browse/HIVE-17477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682313#comment-16682313 ]
Hive QA commented on HIVE-17477: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12947569/HIVE-17477.6.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/14854/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14854/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14854/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ date '+%Y-%m-%d %T.%3N' 2018-11-10 09:57:51.715 + [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]] + export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'MAVEN_OPTS=-Xmx1g ' + MAVEN_OPTS='-Xmx1g ' + cd /data/hiveptest/working/ + tee /data/hiveptest/logs/PreCommit-HIVE-Build-14854/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ git = \s\v\n ]] + [[ git = \g\i\t ]] + [[ -z master ]] + [[ -d apache-github-source-source ]] + [[ ! -d apache-github-source-source/.git ]] + [[ ! -d apache-github-source-source ]] + date '+%Y-%m-%d %T.%3N' 2018-11-10 09:57:51.718 + cd apache-github-source-source + git fetch origin + git reset --hard HEAD HEAD is now at 7ae4a2c HIVE-20833: package.jdo needs to be updated to conform with HIVE-20221 changes (Vineet Garg, reviewed by Jason Dere) + git clean -f -d Removing standalone-metastore/metastore-server/src/gen/ + git checkout master Already on 'master' Your branch is up-to-date with 'origin/master'. + git reset --hard origin/master HEAD is now at 7ae4a2c HIVE-20833: package.jdo needs to be updated to conform with HIVE-20221 changes (Vineet Garg, reviewed by Jason Dere) + git merge --ff-only origin/master Already up-to-date. + date '+%Y-%m-%d %T.%3N' 2018-11-10 09:57:53.178 + rm -rf ../yetus_PreCommit-HIVE-Build-14854 + mkdir ../yetus_PreCommit-HIVE-Build-14854 + git gc + cp -R . ../yetus_PreCommit-HIVE-Build-14854 + mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-14854/yetus + patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hiveptest/working/scratch/build.patch + [[ -f /data/hiveptest/working/scratch/build.patch ]] + chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh + /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch error: a/common/src/main/resources/hive-log4j2.properties: does not exist in index error: a/llap-server/src/main/resources/llap-cli-log4j2.properties: does not exist in index error: a/ql/src/java/org/apache/hadoop/hive/ql/log/PidFilePatternConverter.java: does not exist in index error: a/standalone-metastore/src/main/resources/metastore-log4j2.properties: does not exist in index error: standalone-metastore/src/main/resources/metastore-log4j2.properties: does not exist in index error: src/main/resources/hive-log4j2.properties: does not exist in index error: src/main/resources/llap-cli-log4j2.properties: does not exist in index error: src/java/org/apache/hadoop/hive/ql/log/PidFilePatternConverter.java: does not exist in index error: src/main/resources/metastore-log4j2.properties: does not exist in index The patch does not appear to apply with p0, p1, or p2 + result=1 + '[' 1 -ne 0 ']' + rm -rf yetus_PreCommit-HIVE-Build-14854 + exit 1 ' {noformat} This message is automatically generated. ATTACHMENT ID: 12947569 - PreCommit-HIVE-Build > PidFilePatternConverter not rolling log according to their pid > --------------------------------------------------------------- > > Key: HIVE-17477 > URL: https://issues.apache.org/jira/browse/HIVE-17477 > Project: Hive > Issue Type: Bug > Components: Logging > Reporter: Vlad Gudikov > Assignee: Bohdan Chupika > Priority: Major > Attachments: HIVE-17477.1.patch, HIVE-17477.2.patch, > HIVE-17477.3.patch, HIVE-17477.4.patch, HIVE-17477.5.patch, HIVE-17477.6.patch > > > We can use pid in th filePattern: > appender.DRFA.filePattern = > ${sys:hive.log.dir}/${sys:hive.log.file}.%d{yyyy-MM-dd}.%pid > But when its time roll the logs at the end of the RollingAppender just > renames hive.log by applying the pattern described above and keeps logs that > are not related to the process this log was named by. The issue is that all > processes are writing to the same log and we cannot separate them by pid. -- This message was sent by Atlassian JIRA (v7.6.3#76005)