[
https://issues.apache.org/jira/browse/HIVE-20906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684356#comment-16684356
]
Hive QA commented on HIVE-20906:
--------------------------------
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
35s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
37s{color} | {color:blue} ql in master has 2316 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
53s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
12s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 22m 8s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-14893/dev-support/hive-personality.sh
|
| git revision | master / 5588764 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-14893/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> Hive locks are not really ephemeral
> -----------------------------------
>
> Key: HIVE-20906
> URL: https://issues.apache.org/jira/browse/HIVE-20906
> Project: Hive
> Issue Type: Bug
> Affects Versions: 2.3.0, 2.3.3, 3.1.1
> Reporter: Rajesh KSV
> Priority: Major
> Fix For: 3.1.1
>
> Attachments: ephemeral.patch
>
>
> I am using Hive 2.3.3.
>
> According to docs
> ([https://cwiki.apache.org/confluence/display/Hive/Locking]), they are
> ephemeral. But in the Zookeeper and Hive source Code, they seemed to be
> non-ephemeral.
>
> I ran the following query in Hive.
>
> *lock table discovery.defaultns*
>
> When I see the lock in zookeeper, it doesn't look like ephemeral node.
>
> [zk: localhost:2181(CONNECTED) 55] get
> /hive_zookeeper_namespace/discovery/defaultns/LOCK-EXCLUSIVE-0000000000
>
> hive_20181112191555_d6640955-2806-4fa7-9e52-30d04c377a04:1542030355565:EXPLICIT:lock
> table discovery.defaultns exclusive:10.33.222.139
> cZxid = 0x2400296808
> ctime = Mon Nov 12 19:15:55 IST 2018
> mZxid = 0x2400296808
> mtime = Mon Nov 12 19:15:55 IST 2018
> pZxid = 0x2400296808
> cversion = 0
> dataVersion = 0
> aclVersion = 0
> *ephemeralOwner = 0x0*
> dataLength = 134
> numChildren = 0
>
> Also in the code -
> [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveTxnManagerImpl.java],
> the lock is KeepAlive/PERSISTENT and not EPHIMERAL. Current code is
>
> *HiveLock lck = lockMgr.lock(new HiveLockObject(tbl, lockData), mode,
> true);*
> Instead it should be
> *HiveLock lck = lockMgr.lock(new HiveLockObject(tbl, lockData), mode,
> false);*
> The patch is the same.
> Please correct me if I am wrong. This is my first ever Jira/Patch in Hive
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
